fix themes not displaying due to double video end tags

[joyrider3774]

This should fix the issue with themes not displaying due to double endtags being used in the video xml tag. (issue #310) Not sure why there are so many themes that do this but removing the 1st endtag fixes it in attract and the themes load now, instead of showing just the background. I'm just replacing strings that contain the double video entag, replacing it with one without the double endtag. They always seem to show up on the same place at the same attributes with all the themes i tested/

[mickelson]

hey there, thanks for this

it seems a bit clunky to separately search for each variation where the only difference is the none, left, top... values.

Did you consider using squirrel's regexp.search functionality to do this search using a regular expression? see: http://www.squirrel-lang.org/squirreldoc/stdlib/stdstringlib.html

a regular expression should be able to do the seatch once without caring what those values are... it might not work though since I understand that squirrel's regexp is pretty broken.

[mickelson]

or here's another thought, wouldn't it be simpler to just search for ""/>rest=" and replace that with "" rest="

[joyrider3774]

you are exactly right, i did not think about searching for ""/>rest=" and replacing it with ""rest=". I'll change the code to that. The reason i did not use a regular expression is because i was not familiar with it. At work i let me collegue write them. but i'll give it a shot.