Skip to content

retry on jobComplete == false #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vanetten wants to merge 2 commits into
base: master
Choose a base branch
from
+64 −24
Open

retry on jobComplete == false #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f33f6b9
retry on jobComplete == false
Oct 20, 2015
c99c173
retry on jobComplete == false
Oct 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 32 additions & 12 deletions lib/active_record/connection_adapters/rails_41.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,21 +334,41 @@ def pp(result) # :nodoc:
end
end

# def exec_query(sql, name = nil, binds = [])
# log(sql, name, binds) do

# # Don't cache statements if they are not prepared
# #we set prepared_statements to false in config initialization
# #if without_prepared_statement?(binds)
# result = BigBroda::Jobs.query(@config[:project], {"query"=> sql })
# cols = result["schema"]["fields"].map{|o| o["name"] }
# records = result["totalRows"].to_i.zero? ? [] : result["rows"].map{|o| o["f"].map{|k,v| k["v"]} }
# stmt = records
# #else
# #binding.pry
# #BQ does not support prepared statements, yiak!
# #end

# ActiveRecord::Result.new(cols, stmt)
# end
# end

class JobIncomplete < Exception
end

def exec_query(sql, name = nil, binds = [])
log(sql, name, binds) do

# Don't cache statements if they are not prepared
#we set prepared_statements to false in config initialization
#if without_prepared_statement?(binds)
result = nil
Retriable.retriable on: JobIncomplete, base_interval: 1, max_interval: 5, tries: 60 do
result = BigBroda::Jobs.query(@config[:project], {"query"=> sql })
cols = result["schema"]["fields"].map{|o| o["name"] }
records = result["totalRows"].to_i.zero? ? [] : result["rows"].map{|o| o["f"].map{|k,v| k["v"]} }
stmt = records
#else
#binding.pry
#BQ does not support prepared statements, yiak!
#end

unless result['jobComplete']
log("BigQuery Job Incomplete, trying again, #{Time.now}", nil) {}
raise JobIncomplete
end
end
cols = result["schema"]["fields"].map{|o| o["name"] }
records = result["totalRows"].to_i.zero? ? [] : result["rows"].map{|o| o["f"].map{|k,v| k["v"]} }
stmt = records
ActiveRecord::Result.new(cols, stmt)
end
end
Expand Down
44 changes: 32 additions & 12 deletions lib/active_record/connection_adapters/rails_42.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,21 +358,41 @@ def pp(result) # :nodoc:
end
end

# def exec_query(sql, name = nil, binds = [])
# binding.pry
# log(sql, name, binds) do

# # Don't cache statements if they are not prepared
# #if without_prepared_statement?(binds)
# result = BigBroda::Jobs.query(@config[:project], {"query"=> sql })
# cols = result["schema"]["fields"].map{|o| o["name"] }
# records = result["totalRows"].to_i.zero? ? [] : result["rows"].map{|o| o["f"].map{|k,v| k["v"]} }
# stmt = records
# #else
# #binding.pry
# #BQ does not support prepared statements, yiak!
# #end

# ActiveRecord::Result.new(cols, stmt)
# end
# end

class JobIncomplete < Exception
end

def exec_query(sql, name = nil, binds = [])
binding.pry
log(sql, name, binds) do

# Don't cache statements if they are not prepared
#if without_prepared_statement?(binds)
result = nil
Retriable.retriable on: JobIncomplete, base_interval: 1, max_interval: 5, tries: 60 do
result = BigBroda::Jobs.query(@config[:project], {"query"=> sql })
cols = result["schema"]["fields"].map{|o| o["name"] }
records = result["totalRows"].to_i.zero? ? [] : result["rows"].map{|o| o["f"].map{|k,v| k["v"]} }
stmt = records
#else
#binding.pry
#BQ does not support prepared statements, yiak!
#end

unless result['jobComplete']
log("BigQuery Job Incomplete, trying again, #{Time.now}", nil) {}
raise JobIncomplete
end
end
cols = result["schema"]["fields"].map{|o| o["name"] }
records = result["totalRows"].to_i.zero? ? [] : result["rows"].map{|o| o["f"].map{|k,v| k["v"]} }
stmt = records
ActiveRecord::Result.new(cols, stmt)
end
end
Expand Down