Skip to content

Bug much fixed #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brendongo wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bug much fixed #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e78d42
whitespace
thommahoney Jun 11, 2014
fd1a79f
don't reassign argument variable in function
thommahoney Jun 11, 2014
2fad95e
Color bug much fixed
brendongo Feb 6, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions loge.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<html>
<head>
<style>
body {
font-size: 40px;
color: indianred;
font-family: 'Comic Sans MS', cursive;
}

.doge {
width: 600px;
position: absolute;
top: 60%;
text-align: center;
}
</style>
</head>

<body>
<div class="doge">
web inspector?
</div>

<script src="loge.js"></script>
</body>
</html>
19 changes: 15 additions & 4 deletions loge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,21 @@
}

if (isChrome) {
completeResult = results.join('');
var temp = results;
results = [];
results.push('%c%s');
results.push('font-family: Comic Sans MS; line-height: 2em; font-size: 1.5em; color: ' + randomColor());
results.push(completeResult);
var format = '';
for(var i = 0; i < temp.length; i++){
format = format + '%c%s';
}

results.push(format);

for(var i = 0; i < temp.length; i++){
Copy link
Owner

@michelle michelle Feb 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following the surrounding code, the format of this should be for (var i = 0; i < temp.length; i++) {

Copy link
Owner

@michelle michelle Feb 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protip: most folks prefer for (var i = 0, len = temp.length; i < len; i++) {

var color = randomColor();
results.push('font-family: Comic Sans MS; line-height: 2em; font-size: 1.5em; color: ' + color);
results.push(temp[i] + ',');
}

}

console.log.apply(console, results);
Expand Down Expand Up @@ -224,3 +234,4 @@
exports.console.loge = loge;

})(this);