fix shortcut view disappear when long click on item#59
Open
RuiwenTang wants to merge 1 commit intomichelelacorte:masterfrom
Open
fix shortcut view disappear when long click on item#59RuiwenTang wants to merge 1 commit intomichelelacorte:masterfrom
RuiwenTang wants to merge 1 commit intomichelelacorte:masterfrom
Conversation
Author
you can refer the commits in branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi:
When I compile this launcher and pushed into my phone, I found the Shortcuts view often disappear when I long click on an item.
After reading the code, I think the root cause is because the DragController receive a TouchEvent with ACTION_MOVE type, and in its onTouchEvent callback call ShortcutsCreation.clearAllLayout().
Maybe this is only happening on my phone, but I think do some movement checking is helpful.