Skip to content

Conversation

@michaelstingl
Copy link
Owner

Summary

  • Fix AsyncStorage dependency issues in iOS build
  • Update Podfile to resolve DEFINES_MODULE conflicts between targets
  • Add proper configuration for cocoapods to handle conflicting build settings

Test plan

  • Run app on iOS simulator/device and verify that AsyncStorage works without errors
  • Verify theme selection persistence which relies on AsyncStorage

🤖 Generated with Claude Code

- Update Podfile to resolve DEFINES_MODULE conflicts between targets
- Install @react-native-async-storage/async-storage dependency
- Update project configuration files

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions
Copy link

Coverage after merging fix/ios-asyncstorage into main will be

63.03%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
config
   app.config.ts70%50%100%100%101, 133, 133–134, 134, 85–86, 97, 99
services
   AuthService.ts44.02%36.67%57.14%46.48%109–115, 126–127, 190, 208, 219, 227, 229–231, 234–238, 241, 241, 241, 241, 241, 241–242, 246–247, 254, 254, 254–256, 259, 261, 267, 270, 273, 276, 283, 286, 289, 292, 295, 295, 295–297, 301–303, 306, 309, 309, 309–310, 312–313, 313, 313, 316, 316, 316, 318, 318, 318–322, 322, 322–325, 325, 325–328, 331, 336, 336, 336, 338–339, 341, 341, 341, 341, 341, 343, 343, 343–344, 348, 350, 350, 350, 350, 350, 352–353, 357–358, 362–363, 57–60, 71
   OidcService.ts48.21%36.59%60%54.55%130–133, 138, 138, 15, 155–156, 176, 176, 176–177, 181, 181, 181–183, 186, 186, 186–188, 190, 190–191, 191, 195, 200, 200, 200–201, 205, 205, 205–206, 209, 211, 211, 211, 213–214, 214, 220, 24–25, 34–35, 53–54, 57, 66, 84–87
   WebFingerService.ts89.33%76.92%80%97.73%104–105, 14, 24, 31, 38, 59
services/api
   ApiService.ts75.58%63.64%70%81.48%100, 133, 137, 172, 174, 200, 200, 200–202, 204, 204, 209, 212–213, 227, 86, 93
   HttpUtil.ts59.24%50.54%84.62%62.88%102–103, 103, 103, 106, 106, 106–107, 110, 114, 114, 114–117, 155, 165, 18, 193, 198, 198–199, 203, 222, 305, 31, 312, 34–35, 354, 354, 354–355, 355, 355, 357, 357, 357–359, 36, 362, 362, 362–363, 365, 365, 365–367, 369, 369, 369–370, 373, 39, 396, 410, 42–43, 435–438, 446, 450, 473–475, 51, 59, 59, 59–60, 60, 60–62, 62, 62–63, 63, 63, 65–67, 69, 71, 75, 79, 82, 85, 92, 96, 96

@michaelstingl michaelstingl merged commit 8dab71f into main Mar 19, 2025
4 checks passed
@michaelstingl michaelstingl deleted the fix/ios-asyncstorage branch March 19, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants