fix: add support for ordering a connection by nullable edge fields #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the generated SQL for cursor based pagination was not properly considering that null values were possible. this fix works only for SQL databases that order NULLs first for ASC and last for DESC ent/ent#4059
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated SQL for cursor-based pagination was not properly considering that null values were possible in the field being used for ordering.
This fix works only for SQL databases that order NULLs first for ASC and last for DESC
ent/ent#4059
NOTE: This shouldn't be merged into the upstream repository. These changes will only work for certain SQL dialects.