Skip to content

Fix port number removal #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nytra wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix port number removal #38

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b4a9a4
Don't remove port number from end of port name
Nytra Sep 26, 2025
8e11bb1
Only remove the port number on Windows and remove the extra space at …
Nytra Sep 26, 2025
d012135
Add comment back
Nytra Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions RtMidi.Core/Unmanaged/Devices/Infos/RtMidiDeviceInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using System.Runtime.InteropServices;

namespace RtMidi.Core.Unmanaged.Devices.Infos
{
Expand All @@ -8,10 +9,14 @@ internal RtMidiDeviceInfo(uint port, string name)
{
Port = port;

// RtMidi may add port number to end of name to ensure uniqueness
Name = name.EndsWith(port.ToString())
? name.Substring(0, name.LastIndexOf(port.ToString(), StringComparison.Ordinal))
// RtMidi may add port number to end of name on Windows to ensure uniqueness
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
Name = name.EndsWith(port.ToString())
? name.Substring(0, name.LastIndexOf(port.ToString(), StringComparison.Ordinal) - 1)
: name;
}
else { Name = name; }
}

public uint Port { get; }
Expand Down