Adds support for compose port range syntax #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before I get to the PR: we are currently in the process of switching all of our current descriptors over to other things in order to test out a new cluster internally, and this tool has already provided a lot of value for us. Thanks for all the work this far. It's a small thing, but it's already saved us so much time in the early going.
Issue
Currently,
container-transformwill throw an error when trying to map ingress ports like9090-9091:8080-8081in a docker-compose file.Additions
This PR fixes that case by checking if the port mapping contains the dash character, and handling it appropriately. It also adds support for the other port ranges on the docker-compose v2 docs here with the exception of port ranges that also include the host. If you want that included too, I can make that happen.