Skip to content

test: verify coverage above 80% after dead code removal#4

Closed
miams wants to merge 1 commit intodevelopfrom
test/verify-coverage-improvement
Closed

test: verify coverage above 80% after dead code removal#4
miams wants to merge 1 commit intodevelopfrom
test/verify-coverage-improvement

Conversation

@miams
Copy link
Copy Markdown
Owner

@miams miams commented Oct 15, 2025

Purpose

Verify that test coverage is now above 80% after removing dead code.

Changes in develop branch

  1. ✅ Removed rmagent/generators/biography.py (817 lines, 0% coverage)
  2. ✅ Removed rmagent/rmlib/prototype.py (348 lines, 0% coverage)
  3. ✅ Added OpenAI and Ollama API keys to CI workflow
  4. ✅ Raised coverage threshold from 66% to 80%

Expected Result

Calculated coverage: 82.8% (should pass 80% threshold)

  • Old: 5784 total lines, 1961 missed = 66.1%
  • Removed: 1165 lines of dead code (100% uncovered)
  • New: 4619 total lines, 796 missed = 82.8%

This PR will be closed after verification.

🤖 Generated with Claude Code

@miams
Copy link
Copy Markdown
Owner Author

miams commented Oct 15, 2025

Coverage verified: 83.26% (exceeds 80% threshold)

Dead code removal was successful:

  • Removed 1165 lines of uncovered code
  • Coverage improved from 66.1% → 83.26%
  • All tests passing

Closing this verification PR.

@miams miams closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant