Skip to content

Conversation

@just-maiyak
Copy link
Contributor

@just-maiyak just-maiyak commented Jul 27, 2025

Update gleam_community_colour/ansi.

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Currently, a project depending on glitzer cannot install gleam_json>=3.0.0 because of it's dependency to gleam_community_colour/ansi.
Issue Number: N/A

What is the new behavior?

  • It is now possible to have glitzer+gleam_json>=3.0.0

Does this introduce a breaking change?

  • Yes
  • No

Other information

I was looking into updating gleam_json in the gleam package gleamoire and it depends on glitzer, which depends on gleam_json through gleam_community_colour/gleam_community_ansi, hence this PR :)
This one depends on #36 because it updates gleam_stdlib as well.

@just-maiyak just-maiyak requested a review from miampf as a code owner July 27, 2025 20:54
@miampf miampf changed the title maint(deps): Update gleam/community/ansi and gleam/community/colours deps: Update gleam/community/ansi and gleam/community/colours Jul 27, 2025
@miampf
Copy link
Owner

miampf commented Jul 27, 2025

Thanks a lot for your contributions, they are very welcome since I'm not too active in gleam anymore so I don't realize if things change!

@just-maiyak just-maiyak force-pushed the maint/deps/update-ansi-colours branch from 03d69b4 to 49ecb3d Compare July 27, 2025 21:08
@just-maiyak
Copy link
Contributor Author

Thanks a lot for your contributions, they are very welcome since I'm not too active in gleam anymore so I don't realize if things change!

No worries :) I did not enble workflows on my fork so I didn't see that the CI's not passing. I added a commit to change gleam's version so that it can run. Now a dependency is not happy with the iterator change; Sorry for the plumbing haha

@miampf
Copy link
Owner

miampf commented Jul 27, 2025

Thanks a lot for your contributions, they are very welcome since I'm not too active in gleam anymore so I don't realize if things change!

No worries :) I did not enble workflows on my fork so I didn't see that the CI's not passing. I added a commit to change gleam's version so that it can run. Now a dependency is not happy with the iterator change; Sorry for the plumbing haha

Its all fine, I fixed it :) should be good to merge but please do your own tests to make sure your changes went through as expected :P

@miampf miampf merged commit 396ece6 into miampf:main Jul 27, 2025
1 check passed
@just-maiyak just-maiyak deleted the maint/deps/update-ansi-colours branch July 27, 2025 21:30
@just-maiyak
Copy link
Contributor Author

Its all fine, I fixed it :) should be good to merge but please do your own tests to make sure your changes went through as expected :P

It does work on my end ! Thank you so much for your reactivity this time around as well ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants