Open
Conversation
c2ndev
requested review from
JGiola and
davidebianchi
and removed request for
davidebianchi
Contributor
Contributor
|
Since the PR was heavily outdated I aligned it with main, please make sure the merge went fine and the PR is actually done and ready to be merged. When you confirm we can merge it. |
|
|
||
| const ( | ||
| SentinelMetrics = "sentinel:metrics" | ||
| ProcessSignal = "process:signal" // TO BE IMPLEMENTED |
Contributor
There was a problem hiding this comment.
When is this going to be implemented?
| GCPInventoryPubSub = "gcp-inventory-pubsub" | ||
| AzureActivityLogEventHub = "azure-activity-log-event-hub" | ||
| AWSCloudTrailSQS = "aws-cloudtrail-sqs" | ||
| VM = "vm" |
Contributor
There was a problem hiding this comment.
isn't the "vm" name too vague? Can it be changed to something more specific and clear to the final user?
Contributor
|
I noticed CI is failing because the branch is using stuff that has been moved around on main while the branch was stale. I didn't follow the changes that are causing the issues here but let me know if you need help figuring out what has happened and what changes are supposed to be made here to restore CI :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to introduce a new webhook source
vm.This new events are generated from another agent running on a specific Virtual Machine which should monitor system and the processes running on it:
Project Repo here