Skip to content

4216 ictextfield allow validation text be provided via a slot #4225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
GCHQ-Developer-299 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

4216 ictextfield allow validation text be provided via a slot #4225

GCHQ-Developer-299 wants to merge 3 commits into from
+81 −15

Conversation

@GCHQ-Developer-299
Copy link
Contributor

@GCHQ-Developer-299 GCHQ-Developer-299 commented Jan 29, 2026 •
edited
Loading

Summary of the changes

Added validation-message slot to ic-input-validation, which will support further slotted validation text

Added validation-text slot to text-field

Related issue

#4216

Checklist

General

  • Changes to docs package checked and committed.
  • All acceptance criteria reviewed and met.

Testing

  • Relevant unit tests and visual regression tests added.
  • Playground stories in React Storybook up to date, with any prop changes and additions addressed.

Accessibility

  • Accessibility Insights FastPass performed.
  • A11y unit test added and yields no issues.
  • A11y plug-in on Storybook yields no issues.
  • Manual screen reader testing performed using NVDA and VoiceOver.

Testing content extremes

  • All prop combinations work without issue.
  • Props/slots can be updated after initial render.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2026

View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/4216-ictextfield-allow-validation-text-be-provided-via-a-slot/web-components
View your React branch deployment here: https://mi6.github.io/ic-ui-kit/branches/4216-ictextfield-allow-validation-text-be-provided-via-a-slot/react

@GCHQ-Developer-299 GCHQ-Developer-299 force-pushed the 4216-ictextfield-allow-validation-text-be-provided-via-a-slot branch 4 times, most recently from 9d27e2e to 52bc4ad Compare January 29, 2026 12:26
@GCHQ-Developer-299
feat(web-components): add validation-text slot to ic-text-field
c1bc6c4 
Add validation-text slot to ic-text-field component, add validation-message slot to
ic-input-validation

ref #4216
@GCHQ-Developer-299
docs(docs): add validation-text and validation-message slot docs for …
de15ae2 
…ic-text-field

ref #4216
@GCHQ-Developer-299
feat(react): tests for validation-text slot on ic-text-field
edd5a6a 
Add visual regression test for icTextfield should render slotted validation-text
feat(react): update Cypress visual regression test baseline images

ref #4216
@GCHQ-Developer-299 GCHQ-Developer-299 force-pushed the 4216-ictextfield-allow-validation-text-be-provided-via-a-slot branch from 52bc4ad to edd5a6a Compare January 29, 2026 12:29
@GCHQ-Developer-299 GCHQ-Developer-299 marked this pull request as ready for review January 29, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GCHQ-Developer-299