Skip to content

Conversation

@GCHQDeveloper416
Copy link
Contributor

@GCHQDeveloper416 GCHQDeveloper416 commented Jan 29, 2026

Summary of the changes

Tell us, in a few words, what the changes are.

change console.error to console.warn ic-pagination-bar

Related issue

Tell us the issue number. If suggesting an improvement or component, please discuss it with us in an issue first.

Internal issue #3138

Checklist

General

  • Changes to docs package checked and committed.
  • All acceptance criteria reviewed and met.

Testing

  • Relevant unit tests and visual regression tests added.
  • Visual testing against Figma component specification completed.
  • Playground stories in React Storybook up to date, with any prop changes and additions addressed.
  • Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

  • Accessibility Insights FastPass performed.
  • A11y unit test added and yields no issues.
  • A11y plug-in on Storybook yields no issues.
  • Manual screen reader testing performed using NVDA and VoiceOver.
  • Manual keyboard testing for keyboard controls and logical focus order.
  • Correct roles used and ARIA attributes used correctly where required.
  • Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

  • Page can be zoomed to 400% with no loss of content.
  • Screen magnifier used with no issues.
  • Text resized to 200% with no loss of content.
  • Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

  • Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • Windows High Contrast mode tested with no loss of content.
  • System light and dark mode tested with no loss of content.
  • Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

  • Min/max content examples tested with no loss of content or overflow.
  • All prop combinations work without issue.
  • Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
  • Controlled and uncontrolled input components tested.
  • Props/slots can be updated after initial render.

@github-actions
Copy link
Contributor

View your canary branch deployment here: https://mi6.github.io/ic-ui-kit/branches/3138-error-to-warn/canary-web-components
View your canary React branch deployment here: https://mi6.github.io/ic-ui-kit/branches/3138-error-to-warn/canary-react

@GCHQDeveloper416 GCHQDeveloper416 force-pushed the 3138-error-to-warn branch 3 times, most recently from ff17af0 to f659c08 Compare January 29, 2026 11:44
@GCHQDeveloper416 GCHQDeveloper416 marked this pull request as ready for review January 29, 2026 11:47
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to rebase against develop, this commit is from a different recent change

@GCHQDeveloper416 GCHQDeveloper416 marked this pull request as draft January 29, 2026 12:08
@GCHQDeveloper416 GCHQDeveloper416 marked this pull request as ready for review January 29, 2026 13:24
@GCHQ-Developer-299 GCHQ-Developer-299 merged commit 18c062c into develop Jan 29, 2026
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants