Feat/3933 angular native wrappers #4054
Conversation
|
Raising this PR ahead of time while I work on some component tests to get opinions/check I haven't missed anything large |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome 👋
Welcome to the ic-ui-kit repo, thank you for submitting a pull request!
How to contribute
Please read our CONTRIBUTING.md, which explains our ways of working and guidelines for contributions.
Code of Conduct
We'd appreciate it if you could read and abide by our Code of Conduct, as we wish to foster an inclusive and respectful community.
Targeting your pull request
We use develop rather than main as the base for contributions - please make sure your PR is targeting develop.
Signing the CLA
We require all contributors to sign our Contributor License Agreement (CLA) before we can accept a contribution. If you are contributing on behalf of an organization please follow your organization's policies in signing CLAs.
Associated issue
Please make sure that your pull request has an issue open - this allows us to keep track of changes made and offer support where needed.
|
I can review this later if wanted. A couple of places we can improve logic. |
Please do, I'm having an interesting time getting cypress set up for the angular side, and when I was about to push up the quick fixes to add the scope and remove the general linting from the angular package (as per the react one) I now have some important vulnerabilities being flagged by the commit processor! |
|
CC me when this is ready for review 👍🏾 |
GCHQDev01001010
force-pushed
the
feat/3933-angular-native-wrappers
branch
from
f6e9ecd to
2f11a6c
Compare
packages/angular/standalone/src/directives/angular-component-lib/utils.ts
Show resolved
Hide resolved
MI6-255
left a comment
MI6-255
left a comment
There was a problem hiding this comment.
Marking as requested changes simply to prevent merging whilst the team has internal discussions on this PR
GCHQDev01001010
force-pushed
the
feat/3933-angular-native-wrappers
branch
from
48c2ddb to
f06b421
Compare
GCHQDev01001010
force-pushed
the
feat/3933-angular-native-wrappers
branch
3 times, most recently
from
ac54468 to
fe2261c
Compare
Set up new output targets in the stencil config to output native angular wrapper components in a similar vein to the react components. Versions have been included that will allow the integrating developers to import the components as standalone items one-by-one at need or as a whole module. This also required the addition/alteration of the custom-elements-dist output to create an internal package for the web-components that the angular output plugin could use. re mi6#3933 feat(angular): updated proxies following changes on develop refactor(angular): added angular to the pack tars script, included package.json entry for ng-add feat(angular): uplifts Ng native componnets to latest changes & fixes "ng add" schematic re mi6#3933 feat(root): included angular output targets to produce native wrappers Set up new output targets in the stencil config to output native angular wrapper components in a similar vein to the react components. Versions have been included that will allow the integrating developers to import the components as standalone items one-by-one at need or as a whole module. This also required the addition/alteration of the custom-elements-dist output to create an internal package for the web-components that the angular output plugin could use. The package is included in the pack all script and other checks. Also includes an Angular schematic in the package so users can install simply with "ng add"
…he new wrapped components re mi6#3933
Removes generic linting from angular to be more in line with the react components. Adds references to the angular package in various workflow configs. Updates the contributing docs with reference to angular package where the react native components are already highlihgted re mi6#3933 style(angular): addresses PR comments feat(angular): updates angular package to version 3.16 and fixes some packaging config issues chore(angular): responding to review comment refactor(angular): changes angular package name to include community status Also adds some more notes to the readme as per agreements with ICDS team chore(angular): adding updated package-lock chore(angular-community-supported): fixes audit concerns with package updates and uolifts to 3.17.0 feat(angular-community-developed): fixing pipeline issues and renames package Removes generic linting from angular to be more in line with the react components. Adds references to the angular package in various workflow configs. Updates the contributing docs with reference to angular package where the react native components are already highlihgted Package renamed to reflect community driven nature. Also adds some more notes to the readme as per agreements with ICDS team regarding package ownership. re mi6#3933
…ableTimes' prop Modify the disableTimes prop in time-input and time-selector to remove ability to set individual times BREAKING CHANGE: Modified IcDisableTimeSelection type, affecting disableTimes prop ref mi6#3949
Update the description omf the disableTimes prop used in time components ref mi6#3949
…isableTimes Updated disableTime examples in Time Input and Selector stories, including playgrounds. ref mi6#3949
Update audit ci with new vulnerability
…scope check and fixes prettier chore(angular-community-supported): removed redundant scope mapping style(angular-community-supported): adds new angular package name to scope check and fixes prettier
GCHQDev01001010
force-pushed
the
feat/3933-angular-native-wrappers
branch
from
199081d to
0ce3454
Compare
|
I've moved the changes over to a new branch to make the commit scoping neater. |
5 participants
Summary of the changes
Enabled angular output target in stencil config to create native angular library output.
This change set also provides an angular schematic for ease of integration with consumer apps and updates in-repo documentation for using ICDS with Angular.
Related issue
#3933
& ic-design-system 850
Checklist
General
Testing
Accessibility
Resize/zoom behaviour
System modes
Testing content extremes