Improve signup validation and fix request_comment RLS policy #331
+17
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Zod UUID validation for signup referrer parameter to prevent open redirect attacks (was only type-cast, not validated at runtime) - Add WITH CHECK clause to request_comment UPDATE RLS policy to prevent potential uid field modification during updates https://claude.ai/code/session_014CaZaFxxsPGPuygRGo88c4
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Updates to Preview Branch (claude/unable-to-assist-8CqAb) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves type safety in the signup route validation and fixes a security issue in the request_comment table's Row Level Security (RLS) policy.
Key Changes
Signup validation: Replaced manual type definition with Zod schema validation for the
referrersearch parameterSearchSchemausing Zod for runtime validation of UUID formatuuidtype importsafeParsefor safer validation with fallback to empty object on failureDatabase security: Fixed request_comment UPDATE RLS policy
WITH CHECKclause to the "Users can update own comments" policyuidfield during updates while maintaining read access controlUSINGandWITH CHECKconditions match for proper security enforcementImplementation Details
The signup validation now uses Zod's built-in UUID validation (
z.string().uuid()) instead of relying on a custom type, providing better runtime safety and clearer intent. The optionalreferrerparameter is properly validated before being passed to the component.The RLS policy fix ensures that authenticated users can only update their own comments and cannot escalate privileges by changing the
uidfield to another user's ID.