Added SanitizeHost to fix host / hostname with protocol #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ostname that has http or https protocol in it.
|
+1 is there something preventing this PR from being merged? Would love to see it in a release 😄 |
Owner
|
Yeah, hard to balance something like this – a |
|
I somewhat agree, if the library shouldn't sanitise, then it could at least throw some sort of validation error? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a method to remove
httpandhttpsprotocols in case the user passes it in the request. It might be an edge case but improves the safety of the code. Also added some test cases.