Remove dynamic function loading checks for old Windows versions#2711
Remove dynamic function loading checks for old Windows versions#2711Avasam wants to merge 2 commits intomhammond:mainfrom
Conversation
Avasam
force-pushed
the
stop-dynamically-loading-old-functions
branch
from
58b2278 to
9b8a083
Compare
Avasam
force-pushed
the
stop-dynamically-loading-old-functions
branch
2 times, most recently
from
396a1e3 to
15bb312
Compare
| ("CRYPT_DECRYPT_MESSAGE_PARA_HAS_EXTRA_FIELDS", None), | ||
| # Minimum Windows version supported (Windows 7) | ||
| # https://learn.microsoft.com/en-us/cpp/porting/modifying-winver-and-win32-winnt | ||
| # Technically official Python 3.9 builds require at least Windows 8.1, but we had no reason to bump this |
There was a problem hiding this comment.
Everywhere online, including official docs, it's mentioned that Python 3.9 dropped Windows 7, but I guess they just jumped over 8.0
Avasam
force-pushed
the
stop-dynamically-loading-old-functions
branch
from
15bb312 to
cf2e344
Compare
This comment was marked as resolved.
This comment was marked as resolved.
| // This totally sucks - a single .cpp file can't #include both winhttp.h | ||
| // and wininet.h! SWIG doesn't allow multiple .i files to build a single | ||
| // module! Which leaves us with C++. | ||
| // and wininet.h on Windows 8.1! (ok on 10 and 11?) SWIG doesn't allow |
There was a problem hiding this comment.
Whilst working on this, Both the CI (Windows 10 and 11), and my local Windows 10 machine worked with both includes (likely the type definitions are now the same), but failed in a Windows 8.1 VM.
|
|
||
| // @pymethod |PyConsoleScreenBuffer|SetConsoleFont|Changes the font used by the screen buffer | ||
| // @comm Function is not documented on MSDN | ||
| // @comm Function is not documented on MSDN and removed in Windows 10.0.1607 |
There was a problem hiding this comment.
SetConsoleFont is not available at all in the Win 10 SDK. So we can't do this check at build time.
Since it's undocumented, the only reference I could find to this being removed specifically in Build 1607 comes Wine: https://list.winehq.org/archives/list/wine-devel@list.winehq.org/thread/IJ23HD6IDQDEA3ZX2UPZ6B6W4DN2AD3F/#UT22YE2HDV367XMCIDS72X2P2CPCKXF5
| @@ -27,24 +27,11 @@ PyObject *PyLoadPerfCounterTextStrings(PyObject *self, PyObject *args) | |||
| { | |||
| BOOL bQuiet = 1; | |||
There was a problem hiding this comment.
Isn't the bQuiet param in PyLoadPerfCounterTextStrings and PyUnloadPerfCounterTextStrings completely unused ?
Avasam
force-pushed
the
stop-dynamically-loading-old-functions
branch
2 times, most recently
from
2ed117a to
079ee80
Compare
Avasam
force-pushed
the
stop-dynamically-loading-old-functions
branch
from
079ee80 to
ab4f801
Compare
2 participants
Follow-up to #2667 + #2400 + #2669
These were found by searching for
CHECK_\w+?P(TR|FN),#define CHECK_,pfn\w+?\s?=\sNULL,this version of Windows,on this platform,available on,GetProcAddress(