Extract /MANIFEST:NO from MSVCCompiler hack and improve types#2691
Merged
Avasam merged 5 commits intomhammond:mainfrom Feb 11, 2026
Merged
Conversation
Avasam
force-pushed
the
try-simplifying-MSVCCompiler-hacks-remove-def-spawn
branch
from
2e26047 to
722117c
Compare
Avasam
changed the title
/MANIFEST:NO from MSVCCompiler hack/MANIFEST:NO from MSVCCompiler hack and improve types
Avasam
deleted the
try-simplifying-MSVCCompiler-hacks-remove-def-spawn
branch
Collaborator
Author
|
You're welcome! The PRs linked under #2588 shall further reduce build warnings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting really close to completely and cleanly removing the compiler hack entirely !
/MANIFEST:NOfrom the compiler hack into a more reasonable locationLNK4075that would still appear even with the previous version of the compiler hack (that's now handled by calls toremove_manifest_flags)Just waiting for pypa/setuptools#4986 / pypa/distutils#370 next.