Closed
Conversation
433abb6 to
4ae5fba
Compare
mhammond
requested changes
Apr 18, 2025
Owner
mhammond
left a comment
There was a problem hiding this comment.
Please split this into 2 so it's clear what is being fixed vs what is being improved. The changelog should only list things which would be observable (ie, where the repr output changes). Type annotations for repr also seem pointless to me.
This was referenced Apr 19, 2025
Collaborator
Author
|
Split up in:
(There's some overlap so merge conflicts are to be expected) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following from the change entry:
win32com.client.build.MapEntry'sreprrepr:win32rcparser.StringDefwin32pdhquery.QueryErrorpywin.tools.browser.HLIPythonObjectwin32comext.axscript.client.pyscript.NamedScriptAttributewin32comext.axscript.client.error.AXScriptExceptionwin32comext.axdebug.debugger.ModuleTreeNodewin32com.server.exception.COMExceptionwin32com.client.VARIANTevalstring representation when callingrepr:pywin.tools.browser.HLIPythonObjectwin32comext.axscript.client.pyscript.NamedScriptAttributewin32comext.axscript.client.error.AXScriptExceptionwin32com.server.exception.COMExceptionAs well as using f-string in
repr