Generate help file during build rather than as a separate CI step#2432
Draft
Avasam wants to merge 23 commits intomhammond:mainfrom
Draft
Generate help file during build rather than as a separate CI step#2432Avasam wants to merge 23 commits intomhammond:mainfrom
Avasam wants to merge 23 commits intomhammond:mainfrom
Conversation
Avasam
commented
Nov 19, 2024
Avasam
commented
Nov 19, 2024
Collaborator
Author
|
"but it worked on my machine!"... (and I tried to make sure to test from clean installs !) It's also annoyingly basically the same error as in #2392 |
Avasam
commented
Jan 7, 2025
…m/pywin32 into restore-shipping-help-file
…re-shipping-help-file
…re-shipping-help-file
…m/pywin32 into restore-shipping-help-file
…re-shipping-help-file
This was referenced Apr 19, 2025
Collaborator
Author
|
Hang on, help files are back in non-arm64 wheels since Python 309...
I'll update the scope of this PR and probably do a separate PR for the now-outdated doc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This generates and includes the help file in the setuptools build, rather than it being a separate CI-only step as before.
This has the advantage that pip installing from source should now always include the help file.
Since helpfiles have been restores, that also means that we should theorically be able to update the online doc from GitHub artifacts instead of downloading/installing from PyPI. (I think that'll require merging the workflow files though).