Add flag to skip version detection #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CockroachDB supports the PostgreSQL wire protocol, and both libpq and sqlx will transparently connect to an instance. Unfortunately, dat can't connect, because it automatically calls
SHOW server_version_number;on connection, and cockroach doesn't set that variable. This makes me sad, because CockroachDB and dat are both awesome, and it would be great to use them together.This PR adds a flag
dat.SkipVersionDetection, set to false by default, which allows users to skip the initial version detection. As far as I can tell, setting that flag is all that is needed to allow dat to connect to cockroach as well as postgres.