Preserve Skill Planner grid scroll position across plan updates#115
Open
SamFinni wants to merge 1 commit intomgoeppner:mainfrom
Open
Preserve Skill Planner grid scroll position across plan updates#115SamFinni wants to merge 1 commit intomgoeppner:mainfrom
SamFinni wants to merge 1 commit intomgoeppner:mainfrom
Conversation
The lvSkills ListView was resetting its scroll position to the top on every plan/character change because TopItem (LVM_SCROLL) is silently ignored while WM_SETREDRAW is FALSE inside BeginUpdate/EndUpdate. focusedItem.Focused also triggers EnsureVisible, compounding the issue. Fix: capture the top-visible item's tag hash before the rebuild and restore it via a new RestoreScrollPosition() helper called after EndUpdate() in both UpdateSkillList() and UpdateListColumns(), mirroring the existing StoreSelection/RestoreSelection pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lvSkillsListView resetting scroll to the top on every plan updateRoot cause
TopItem(usesLVM_SCROLLinternally) is silently ignored whileWM_SETREDRAWisFALSEinsideBeginUpdate/EndUpdate. Additionally,focusedItem.Focused = truetriggersEnsureVisible, which scrolls away from the saved position beforeEndUpdateeven fires.Fix
Capture the top-visible item's tag hash before the rebuild and restore it via a new
RestoreScrollPosition()helper called afterEndUpdate()in bothUpdateSkillList()andUpdateListColumns()- mirroring the existingStoreSelection/RestoreSelectionpattern.