Performance improvements for many characters#113
Open
cryonox wants to merge 6 commits intomgoeppner:mainfrom
Open
Performance improvements for many characters#113cryonox wants to merge 6 commits intomgoeppner:mainfrom
cryonox wants to merge 6 commits intomgoeppner:mainfrom
Conversation
…iring in one second
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are a series of improvements for characters more than 30+ where evemon either crashes or take over 3-4 minutes(bruh!) before it can even become responsive! With the fixes the same 30+ character set finshed loading in 10 second, a 24x improvement.
Fix IndexOutOfRangeException on concurrent collection modification — Snapshot lists (
.ToList()/.ToArray()) before iterating in industry job notification,IndustryJobCollection, andGlobalNotificationCollectionwhere timer ticks or re-entrantThreadSafeInvokecould mutate mid-iteration. Also fixed race condition inEveIDToNameswhere it can trigger io excptions.Lazy-load CharacterMonitor controls — Only create the heavy
CharacterMonitorwhen a tab is first selected, not upfront for every character. Same treatment forKillLogCollectioncache andTimerTicksubscription. Header/footer now self-populate on load so they aren't blank.Coalesce redundant UI updates — Overview sets a dirty flag and flushes on
TimerTickinstead of rebuilding per character update.MonitoredCharactersChangedfires once after import, not per character.LayoutTabPagesbatches tab changes viaSuspendLayout/Clear/AddRange/ResumeLayoutinstead of per-tabInsert/Remove. Think of it this way, the liberal use of event driven design during initial startup force many updates to UI thread viaThreadSafeInvoke. This change instead delay and group the updates via one second ticks from the dispatcher instead of allowing simultaneous UI updates.Guard
ThreadSafeInvokeagainst disposed controls — SkipBeginInvoke/EndInvokewhen the target control is already disposed or has no handle. Else this could throwIndexOutOfRangeException.. During startup if you resize the control, it seems this does not prevent this error. So another commit to conditionallycatchthis if it slipped through the guard.