fix(buildStatus): use sessionSecret instead of token#4
Open
xcarpentier wants to merge 3 commits intomglagola:masterfrom
Open
fix(buildStatus): use sessionSecret instead of token#4xcarpentier wants to merge 3 commits intomglagola:masterfrom
xcarpentier wants to merge 3 commits intomglagola:masterfrom
Conversation
Owner
|
@xcarpentier Thanks for the PR! Is there any harm in including all forms of auth? As in can we keep old headers around as a fallback? FYI: A lot of this lib's functionality was deprecated because expo's command line tool (exp) has a lot of these automation utilities implemented now. See github.com/mglagola/exptool/wiki/Deprecations |
Author
|
Hi @mglagola, I wasn't sure but I guess sessionSecret was there before last exp version, no? (I will figured out) If not I will change the PR to integrate expo's command line tool: yes I know, my use case is that I need to keep build chain as it is but just upgrade without changing code for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.