Skip to content

fix: improve lighthouse type definitions#232

Open
namoscato wants to merge 1 commit intomfrachet:masterfrom
namoscato:types
Open

fix: improve lighthouse type definitions#232
namoscato wants to merge 1 commit intomfrachet:masterfrom
namoscato:types

Conversation

@namoscato
Copy link
Copy Markdown

@namoscato namoscato commented Oct 19, 2023

  • add task optional callback argument
  • update command arguments from any ➡️ respective lighthouse/core types

* add task optional callback argument
* update command arguments from any -> respective lighthouse/core types
@HakuTheWolfSpirit
Copy link
Copy Markdown

@mfrachet what is the status of this? Can this be in the next release?

@af-owe
Copy link
Copy Markdown

af-owe commented May 8, 2024

Hey, I forked the package, fixed the typings, allowed selecting the html element with errors in pa11y and updated pa11y and lighthouse. Also extended the README, replaced the examples and published to NPM. It is now only one package for both pa11y and lighthouse. I did not want to manage multiple npm packages. But it should be explained here:

https://github.com/appsfactorygmbh/cypress-audit

npm i -D @appsfactory/cypress-audit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants