Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR streamlines the repository’s workflow-review guidance to focus reviewers on durable correctness and diagnosability checks, while removing PyYAML-specific local validation instructions.
Changes:
- Rewords local setup guidance to recommend running
bash .codex/install.shbefore performing local workflow/tooling checks. - Replaces PyYAML parsing examples with a general rule to use an appropriate YAML-aware validator for workflow files.
- Clarifies that missing local YAML validation dependencies should be treated as an environment/tooling limitation, not a workflow syntax failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
.github/instructions/workflows.instructions.mdto keep core reviewer priorities (trigger correctness, path filters, checkout depth/history assumptions, merge-base logic, matrix behavior, and diagnosability) and the rule to avoid style-only comments.bash .codex/install.shbefore local workflow or tooling checks.Use an appropriate YAML-aware validator for workflow filesand to treat missing local validator dependencies as an environment/tooling limitation rather than a workflow syntax failure.Testing
Codex Task