Conversation
There was a problem hiding this comment.
Pull request overview
Updates the release publishing workflow to use the repository’s .NET 8 toolchain line, matching how CI builds are produced and reducing the chance of publishing artifacts with a divergent SDK.
Changes:
- Switch
.github/workflows/release.ymlfromdotnet-version: 6.0.x(+dotnet-quality: preview) todotnet-version: 8.0.x. - Remove the
dotnet-quality: previewoverride. - Add an inline comment documenting the intent to align with repo-managed SDK usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
global.json,.codex/install.sh, and the main build workflow so published artifacts are built against the same toolchain and avoid accidental divergence.Description
.github/workflows/release.ymlto setdotnet-version: '8.0.x', remove thedotnet-quality: 'preview'override, and add a short inline comment explaining the intentional alignment with the main build toolchain.Testing
git diff --checkwhich completed with no issues; attempted a YAML parse check using Python (yaml.safe_load) but it could not run becausePyYAMLis not installed in this environment.Codex Task