Skip to content

Tighten workflow version file checks to include CHANGELOG.md#787

Merged
mfoltz merged 1 commit intomainfrom
codex/tighten-file-immutability-check-in-workflows-2026-03-21t21-46-26z
Mar 21, 2026
Merged

Tighten workflow version file checks to include CHANGELOG.md#787
mfoltz merged 1 commit intomainfrom
codex/tighten-file-immutability-check-in-workflows-2026-03-21t21-46-26z

Conversation

@mfoltz
Copy link
Copy Markdown
Owner

@mfoltz mfoltz commented Mar 21, 2026

Motivation

  • Enforce immutability for every canonical repo-owned version metadata file so CI cannot accidentally modify tracked version information during the build/publish flows.

Description

  • Update .github/workflows/build.yml to add a short explanatory comment and include CHANGELOG.md in the git diff --exit-code -- ... guard (replacing git diff --exit-code -- "$csproj" thunderstore.toml) in the build_verification, publish_prerelease, and publish_feature_testing_prerelease steps so the same canonical file set is checked consistently.

Testing

  • Ran rg -n "Verify canonical version files remain unchanged|git diff --exit-code --|Canonical repo-owned version files" .github/workflows/build.yml, git diff -- .github/workflows/build.yml, and git show --stat --oneline --decorate=short HEAD; all commands returned the expected results and completed successfully.

Codex Task

Copilot AI review requested due to automatic review settings March 21, 2026 21:46
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens the CI immutability guard in .github/workflows/build.yml so that all canonical, repo-owned version metadata files are consistently checked for unintended modifications during CI runs.

Changes:

  • Adds an explanatory comment clarifying the intent of the immutability guard.
  • Extends the existing git diff --exit-code -- ... guard to include CHANGELOG.md alongside the discovered .csproj and thunderstore.toml.
  • Applies the same canonical file set consistently across build_verification, publish_prerelease, and publish_feature_testing_prerelease.

@mfoltz mfoltz merged commit b1be3d8 into main Mar 21, 2026
10 checks passed
@mfoltz mfoltz deleted the codex/tighten-file-immutability-check-in-workflows-2026-03-21t21-46-26z branch March 21, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants