Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens the CI immutability guard in .github/workflows/build.yml so that all canonical, repo-owned version metadata files are consistently checked for unintended modifications during CI runs.
Changes:
- Adds an explanatory comment clarifying the intent of the immutability guard.
- Extends the existing
git diff --exit-code -- ...guard to includeCHANGELOG.mdalongside the discovered.csprojandthunderstore.toml. - Applies the same canonical file set consistently across
build_verification,publish_prerelease, andpublish_feature_testing_prerelease.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
.github/workflows/build.ymlto add a short explanatory comment and includeCHANGELOG.mdin thegit diff --exit-code -- ...guard (replacinggit diff --exit-code -- "$csproj" thunderstore.toml) in thebuild_verification,publish_prerelease, andpublish_feature_testing_prereleasesteps so the same canonical file set is checked consistently.Testing
rg -n "Verify canonical version files remain unchanged|git diff --exit-code --|Canonical repo-owned version files" .github/workflows/build.yml,git diff -- .github/workflows/build.yml, andgit show --stat --oneline --decorate=short HEAD; all commands returned the expected results and completed successfully.Codex Task