Skip to content

feat: Add cwd option to use relative paths for compiler args#14

Open
nandenjin wants to merge 20 commits intomezum:mainfrom
nandenjin:feat/add-cwd-option
Open

feat: Add cwd option to use relative paths for compiler args#14
nandenjin wants to merge 20 commits intomezum:mainfrom
nandenjin:feat/add-cwd-option

Conversation

@nandenjin
Copy link
Copy Markdown
Contributor

@nandenjin nandenjin commented Oct 16, 2020

Resolves #13

Proposal

  • Add cwd as loader option. If specified, change paths that are passed to compilers to relative ones.
  • Update README to follow the above change.

Note

I add some conversion codes before executions of utility.execute(), but originally paths are explicitly converted to be absolute at process(), so it may be more simple to make paths to be handled as relative internally.

My implementation intends not to add breaking changes to the original behavior (yes, it should make no changes as long as you don't use the cwd option), but if requested, I'll try another way.

@nandenjin
Copy link
Copy Markdown
Contributor Author

nandenjin commented Oct 16, 2020

Since this PR is based on my personal motivation, I want to provide a working sample for it, but I cannot because my use case is based on separated proposal #9. When #13 (my PR for #9) is merged I'll try to provide some working sample here.

(I don't mind if it is merged by maintainers' decisions before I do it 👍)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to use relative path for compiler arguments

1 participant