feat: Add cwd option to use relative paths for compiler args#14
Open
nandenjin wants to merge 20 commits intomezum:mainfrom
Open
feat: Add cwd option to use relative paths for compiler args#14nandenjin wants to merge 20 commits intomezum:mainfrom
nandenjin wants to merge 20 commits intomezum:mainfrom
Conversation
fix: add missing -c flag
Contributor
Author
|
Since this PR is based on my personal motivation, I want to provide a working sample for it, but I cannot because my use case is based on separated proposal #9. When #13 (my PR for #9) is merged I'll try to provide some working sample here. (I don't mind if it is merged by maintainers' decisions before I do it 👍) |
This was referenced Oct 27, 2020
feat: Accept commands and paths for options
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #13
Proposal
cwdas loader option. If specified, change paths that are passed to compilers to relative ones.READMEto follow the above change.Note
I add some conversion codes before executions of
utility.execute(), but originally paths are explicitly converted to be absolute atprocess(), so it may be more simple to make paths to be handled as relative internally.My implementation intends not to add breaking changes to the original behavior (yes, it should make no changes as long as you don't use the
cwdoption), but if requested, I'll try another way.