Merge v25.8.0 #52
Merged
Merge v25.8.0 #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ezra Odio <eodio@starfishstorage.com>
* Split out secrets requiring workflows * Update target * Update Cypress run command
…RY_RESULT_TABLE. (getredash#7296) * prevent text values in payload being detected as 'set' on send. Webex send ERROR:: Object of type set is not JSON serializable Signed-off-by: Matt Nelson <metheos@gmail.com> * add support for formatted QUERY_RESULT_TABLE in webex card Signed-off-by: Matt Nelson <metheos@gmail.com> * don't try to send to blank destinations Signed-off-by: Matt Nelson <metheos@gmail.com> * fix handling of the encoded QUERY_RESULTS_TABLE text Signed-off-by: Matt Nelson <metheos@gmail.com> * re-sort imports for ruff Signed-off-by: Matt Nelson <metheos@gmail.com> * change formatter to black Signed-off-by: Matt Nelson <metheos@gmail.com> * Add additional tests for Webex notification handling ensure blank entries are handled for room IDs and person emails. ensure that the API is not called when no valid destinations are provided. ensure proper attachment formatting for alerts containing 2D arrays. Signed-off-by: Matt Nelson <metheos@gmail.com> * Add test for Webex notification with 1D array handling This commit introduces a new test case to verify that the Webex notification function correctly handles a 1D array input in the alert body. The test ensures that the expected payload is constructed properly and that the requests.post method is called with the correct parameters. Signed-off-by: Matt Nelson <metheos@gmail.com> --------- Signed-off-by: Matt Nelson <metheos@gmail.com>
When MULTI_ORG is enabled, 'static/' resolves to '<org>/static/'
Co-authored-by: snickerjp <snickerjp@gmail.com>
…e have wrong y-value (getredash#7330)
This fixes the following exception:
```
UnboundLocalError: local variable 'value_is_number' referenced before assignment
File "rq/worker.py", line 1431, in perform_job
rv = job.perform()
File "rq/job.py", line 1280, in perform
self._result = self._execute()
File "rq/job.py", line 1317, in _execute
result = self.func(*self.args, **self.kwargs)
File "redash/tasks/alerts.py", line 36, in check_alerts_for_query
new_state = alert.evaluate()
File "redash/models/__init__.py", line 1002, in evaluate
new_state = next_state(op, value, threshold)
File "redash/models/__init__.py", line 928, in next_state
elif not value_is_number and op not in [OPERATORS.get("!="), OPERATORS.get("=="), OPERATORS.get("equals")]:
```
…eSQL JSON getredash#7339 (2nd try) (getredash#7348) * Sanitize NaN, Infinite, -Infinite causing error when saving as PostgreSQL JSON getredash#7339 (2nd try) * Move json nsanitaize to on the top of json_dumps * Fix comment
Co-authored-by: snickerjp <snickerjp@gmail.com>
…h#7359) * Upgrade plotly.js to version 2 * Fix styling error reported by styled
Fix query list item list sorting - descending order, no triangle mark - ascending order, up triangle mark(▲) - descending order, down triangle mark(▼) - ascending order, no triangle mark - descending order, up triangle mark(▲) - ascending order, down triangle mark(▼) - descending order, no triangle mark "sorting order" have 2-click cycle, but "triangle mark" have 3-click cycle.
To allow user arikfr to publish images to redash/redash and redash/preview. Only use vars.DOCKER_USER and secrets.DOCKER_PASSWORD for authorization.
…" (getredash#7327) This workaround was missing 'if view is not None ' as found in https://github.com/pallets-eco/flask-wtf/pull/419/files Tested with MULTI_ORG enabled.
* Make NULL value visible * Make the representation of NULL value configurable * use display-as-null css class for null-value styling
* Use 12-column layout for dashboard grid Set minSizeX, minSizeY for widgets to 2 since a value of 1 breaks all assumptions of the UI layout. Migration provide transition from 6 to 12 columns for all widgets. * Restyled by prettier
* Added support for Google Oauth Scheme Override (through environment variable) * Refactoring * Refactoring * Applied formatting * Refactoring * Refactoring * Updated comment for `GOOGLE_OAUTH_SCHEME_OVERRIDE` variable * Updated comment for `GOOGLE_OAUTH_SCHEME_OVERRIDE` variable * Removed duplication of url_for function --------- Co-authored-by: kostiantyn-dementiev-op <kostiantyn.dementiev@observepoint.com>
* diff locations ignore * add logging message * Processing Location is not specified
As with other query runners, do not show system tables in the schema list.
imenattatra
force-pushed
the
merge-v25.8.0
branch
from
7d38c65 to
16f465a
Compare
This reverts commit 9f76fda. It does not revert the migrations automatically but keeps the migration file and created a contrary migration file to revert the behavior.
imenattatra
force-pushed
the
merge-v25.8.0
branch
from
16f465a to
4130af7
Compare
thiagogds
approved these changes
Nov 21, 2025
Member
thiagogds
left a comment
thiagogds
left a comment
There was a problem hiding this comment.
Thanks for taking care of the conflicts, especially related to the database :)
Can you coordinate with the @metr-systems/se-team and @helenalebreton for a deeper QA test? I think we should copy a dashboard from production and use the same data sources to make sure it's all working as we expect.
|
@thiagogds @imenattatra I am happy to help QA this but I will I guess need a bit of guidance to what we would like to test. |
Author
|
Thank you @helenalebreton for your help I have created this issue with the QA processes to test and to keep it as documentation also for next time. It would be great if later-on we can work on making these processes automatic sincethey already use cypress in redash , we can have our own tests using cypress for our customized cases like dashboard permissions and especially dynamic widgets. Knowing that we do have unit tests for our customized cases and they were helpful during the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
merge-v25.8.0branch has been created from metr-main and then we merged the upstreamv25.8.0into it.Next steps
How is this tested?