Data to test threshold_interpolation plugin accepts JSON file input #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nterpolation plugin
2 tasks
Contributor
|
Thanks Max, why are there 2 dictionary config files? One called threshold_config and one threshold_config_dict, they look the same. Can you also flesh out this PR with description, links to the issue and associated improver PR and acceptance criteria please. |
Contributor
Author
|
The two dictionary files in the commit ca6e713 were threshold_config_dict.json and threshold_config.json. I have now removed the redundant file threshold_config.json. Thank you for noticing this. |
maxwhitemet
changed the title
Contributor
|
Converting to draft for now as more work needs to be done on the sister PRs post PS47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: #866, #866.
This PR adds 2 threshold JSON files (threshold_config_dict.json and threshold_config_list.json) to test the threshold_interpolation plugin accepts both dictionary input in the format currently found in the thresholding plugin and lists using JSON files.
This PR is associated with #871, which addresses a portion of the larger issue #866.