Skip to content

Conversation

@maxwhitemet
Copy link
Contributor

This PR adds the test data associated with the acceptance tests for #2264.

Copy link
Contributor

@gavinevans gavinevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxwhitemet 👍

I've added a couple of comments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The units for all these files seem to be mm/hr, but the values in the files look like m/s.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These acceptance test inputs are overly small and look like they're just the same as the unit test data. The aim with the acceptance test inputs is to provide something a bit more realistic. A larger domain (50x50 or 100x100) would be helpful to understand the behaviour. It would be helpful to add visualisations of all the inputs and kgos to the ticket.

The current data looks like as below. In this example, it looks like the forecast to larger than the reference so quantile mapping is scaling down the values.
image

@maxwhitemet maxwhitemet force-pushed the mobt_1007_quantile_mapping_test_data branch from 1d6b757 to b800d28 Compare December 31, 2025 13:16
@maxwhitemet
Copy link
Contributor Author

The below images demonstrate that quantile mapping has been appropriately applied.

  • The forecast bias towards lower precipitation rates has been corrected, with the CDF of the transformed forecast aligning well with the reference data
  • Values below 2 mm h-1 (intentionally high for illustration purposes) from the biased forecast have been maintained in the transformed forecast
  • The spatial characteristics of the biased forecast have been maintained in the transformed forecast
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants