EPPT-2590: Fire Severity Index: Add a FireSeverityIndex class to IMPROVER #2255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## EPPT_2411_fire_severity_index_workflow_development #2255 +/- ##
=====================================================================================
Coverage ? 95.25%
=====================================================================================
Files ? 152
Lines ? 15360
Branches ? 0
=====================================================================================
Hits ? 14631
Misses ? 729
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mo-philrelton
force-pushed
the
EPPT_2590_fireseverityindex
branch
from
14a9476 to
64b16f1
Compare
RDP-mo
reviewed
Dec 19, 2025
RDP-mo
left a comment
RDP-mo
left a comment
There was a problem hiding this comment.
Looks good as per our teams chat I'll do some checks on the method this afternoon
ryan-cocking-mo
approved these changes
Dec 30, 2025
Contributor
ryan-cocking-mo
left a comment
ryan-cocking-mo
left a comment
There was a problem hiding this comment.
Tests pass, only one comment relating to a docstring. Approved.
| From Van Wagner and Pickett (1985), Page 8: Equation 31. | ||
|
|
||
| Returns: | ||
| np.ndarray: The calculated DSR values. |
Contributor
There was a problem hiding this comment.
Suggested change
| np.ndarray: The calculated DSR values. | |
| The calculated DSR values. |
Return type in docstring not required. Sphinx/Read the Docs infers from return type hint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EPPT-2590
In order to calculate the daily Fire Severity Index, we require a Fire Severity Index calculation. In the original algorithm this is referred to as Daily Severity Rating (DSR), but we call this class
FireSeverityIndexto align with the requested output name.This class, and associated tests, partially reproduce the Canadian Forest Fire Weather Index from van Wagner and Pickett's 1985 FORTRAN implementation
Testing: