Reduce particles and run time for ecemep_emerson forward test#241
Reduce particles and run time for ecemep_emerson forward test#241heikoklein merged 9 commits intomainfrom
Conversation
|
Need to update snap_ecemep_emerson_expected.nc on threads |
Please set a new name, e.g. snap_ecemep_emerson_expected_20260218.nc . Otherwise all old versions will fail. Please check also if the results are robust with strongly reduced particles. Check e.g. with ifort/ifx (different RNG). |
heikoklein
left a comment
There was a problem hiding this comment.
The code looks ok, but the tests are not robust enough against compiler/RNG-changes.
ifx gives AssertionError: False is not true : Cs137_concentration at time(3): 1628.6971435546875 !~ 1748.637939453125 within 4%
It's possible that the number of particles was selected so high, that different RNG should not matter?
To compile with ifx on PPI:
cd src
rm -f current.mk
ln -s conda_ifx_pkgconfig.mk current.mk
conda activate /disk1/heiko/miniconda3/envs/oneapi
make testPlease update snap.input_ecemep_fimex and the corresponding expected, too, since the setup is very much related.
…able; compatibility with ifx
heikoklein
left a comment
There was a problem hiding this comment.
Adjusted a bit, but now it passes also with ifx. I had to remove the pure concentration tests, since vertical diffusion can be too varying with RNG. Used 1000 particles per release and kept the 9 hours.

Fixes #239