Skip to content

Reduce particles and run time for ecemep_emerson forward test#241

Merged
heikoklein merged 9 commits intomainfrom
fix/speed-up-test
Feb 19, 2026
Merged

Reduce particles and run time for ecemep_emerson forward test#241
heikoklein merged 9 commits intomainfrom
fix/speed-up-test

Conversation

@halvarsu
Copy link
Collaborator

@halvarsu halvarsu commented Feb 17, 2026

Fixes #239

@halvarsu halvarsu requested a review from heikoklein February 17, 2026 20:22
@halvarsu
Copy link
Collaborator Author

Current dry dep and acc conc fields
image

@halvarsu
Copy link
Collaborator Author

Need to update snap_ecemep_emerson_expected.nc on threads

@heikoklein
Copy link
Member

Need to update snap_ecemep_emerson_expected.nc on threads

Please set a new name, e.g. snap_ecemep_emerson_expected_20260218.nc . Otherwise all old versions will fail.

Please check also if the results are robust with strongly reduced particles. Check e.g. with ifort/ifx (different RNG).

Copy link
Member

@heikoklein heikoklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks ok, but the tests are not robust enough against compiler/RNG-changes.

ifx gives AssertionError: False is not true : Cs137_concentration at time(3): 1628.6971435546875 !~ 1748.637939453125 within 4%

It's possible that the number of particles was selected so high, that different RNG should not matter?

To compile with ifx on PPI:

cd src
rm -f current.mk
ln -s conda_ifx_pkgconfig.mk current.mk
conda activate /disk1/heiko/miniconda3/envs/oneapi
make test

Please update snap.input_ecemep_fimex and the corresponding expected, too, since the setup is very much related.

@heikoklein heikoklein self-requested a review February 19, 2026 16:58
Copy link
Member

@heikoklein heikoklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted a bit, but now it passes also with ifx. I had to remove the pure concentration tests, since vertical diffusion can be too varying with RNG. Used 1000 particles per release and kept the 9 hours.

@heikoklein heikoklein merged commit 88eec06 into main Feb 19, 2026
4 checks passed
@heikoklein heikoklein deleted the fix/speed-up-test branch February 19, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Runtime of test for emerson drydep is too slow

2 participants