Added free tangents and Spline.SplitAtTime method #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stormsson
commented
Dec 14, 2020
Comment on lines
280
to
292
|
|
||
| SplineNode newNode = new SplineNode(selection.Direction, selection.Direction + selection.Direction - selection.Position); | ||
| var index = spline.nodes.IndexOf(selection); | ||
| if (index == spline.nodes.Count - 1) | ||
| { | ||
| spline.AddNode(newNode); | ||
| } | ||
| else | ||
| { | ||
| spline.InsertNode(index + 1, newNode); | ||
| } | ||
| selection = newNode; | ||
| serializedObject.Update(); |
Author
There was a problem hiding this comment.
this is the original code It was commented by mistake when testing the new method.
this commit restores it
stormsson
commented
Dec 14, 2020
Comment on lines
280
to
293
| spline.SplitAtTime(5.25f); | ||
|
|
||
| //SplineNode newNode = new SplineNode(selection.Direction, selection.Direction + selection.Direction - selection.Position); | ||
| //var index = spline.nodes.IndexOf(selection); | ||
| //if (index == spline.nodes.Count - 1) | ||
| //{ | ||
| // spline.AddNode(newNode); | ||
| //} | ||
| //else | ||
| //{ | ||
| // spline.InsertNode(index + 1, newNode); | ||
| //} | ||
| //selection = newNode; | ||
| //serializedObject.Update(); |
Author
There was a problem hiding this comment.
this was a wrong commit, the code is restored in 4f6b3b1
|
When will this be added to the asset? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SplineNode
added tangentType enum to define how the direction behaves
added two new fields directionIn, directionOut. (should be tangentIn / tangentOut, but kept old naming convention to avoid confusion)
CubicBezierCurve
Spline
SplineEditor