Benchpress/minebench #5
Conversation
meteorfox
force-pushed
the
benchpress/minebench
branch
from
c2f54cf to
0d382dd
Compare
adhanotia
left a comment
adhanotia
left a comment
There was a problem hiding this comment.
Looks great. Just a couple of minor nits.
| #!/bin/bash | ||
| set -e | ||
| set -x | ||
|
|
There was a problem hiding this comment.
Can we add a section for prerequisites and add the libraries we assume are going to be installed.
Maybe use our test host as baseline and then add any additional libraries that were installed before we can run this benchmark
| #!/bin/bash | ||
| set -e | ||
|
|
||
| /usr/bin/time -p "$@" |
There was a problem hiding this comment.
Time might not always be in /usr/bin. Maybe just call 'time' and assume its added in the path?
There was a problem hiding this comment.
time is a built-in shell command in zsh and bash. /usr/bin/time provides more detailed data. But yes it's true, potentially time might not be installed.
I'll verify with time and see if it's enough. Ideally, Benchpress itself should measure the duration.
meteorfox
force-pushed
the
benchpress/minebench
branch
from
0d382dd to
d7190f7
Compare
Adds MineBench's KMeans, PLSA and RSearch benchmarks.