Blaze update to 1.10.2 and update flow router to ostrio:flow-router-extra #280
Conversation
dr-dimitru
left a comment
dr-dimitru
left a comment
There was a problem hiding this comment.
@vparpoil hope it's not too late :) Just noticed this PR (and another one where I left comments)
Please see my review.
Also in temple line 86 got to be updated to:
| name: 'Lists.show', | ||
| action() { | ||
| BlazeLayout.render('App_body', { main: 'Lists_show_page' }); | ||
| this.render('App_body', { main: 'Lists_show_page' }); |
There was a problem hiding this comment.
this.render('App_body', 'Lists_show_page');| name: 'App.home', | ||
| action() { | ||
| BlazeLayout.render('App_body', { main: 'app_rootRedirector' }); | ||
| this.render('App_body', { main: 'app_rootRedirector' }); |
There was a problem hiding this comment.
this.render('App_body', 'app_rootRedirector');
| name: "NotFound", | ||
| action() { | ||
| BlazeLayout.render('App_body', { main: 'App_notFound' }); | ||
| this.render('App_body', { main: 'App_notFound' }); |
There was a problem hiding this comment.
this.render('App_body', 'App_notFound');
| }, | ||
| activeListClass(list) { | ||
| const active = ActiveRoute.name('Lists.show') | ||
| const active = FlowRouter.current().route.name === 'Lists.show' |
There was a problem hiding this comment.
import { FlowRouter , RouterHelpers } from 'meteor/ostrio:flow-router-extra';
RouterHelpers.name('Lists.show');|
|
||
| // if we are on a private list, we'll need to go to a public one | ||
| if (ActiveRoute.name('Lists.show')) { | ||
| if (FlowRouter.current().route.name === 'Lists.show') { |
There was a problem hiding this comment.
import { FlowRouter , RouterHelpers } from 'meteor/ostrio:flow-router-extra';
RouterHelpers.name('Lists.show');
|
@dr-dimitru thank you for your comments!
Any hint on how to fix those ? |
2 participants
See discussion here : meteor/meteor#11014