Open
Conversation
Organized imports
|
This pull request fixes 1 alert when merging d77336e into 0bf850b - view on LGTM.com fixed alerts:
|
# Conflicts: # src/test/java/com/metamug/mason/tag/TagHandlerTest.java
|
This pull request fixes 1 alert when merging efa6640 into 03f06c1 - view on LGTM.com fixed alerts:
|
Contributor
|
Hope you tested that the config can be overwritten using web.xml since
developers may want to keep the rest api elsewhere
…On Sat, 14 Dec 2019 at 11:18 AM, Kaustubh Damle ***@***.***> wrote:
Added *WebFilter* annotation on Router class to avoid so that entry in
web.xml (*this will work for Servlet API 3.x+)* The default URL pattern
is set to */rest/** which can be overwritten from web.xml file
<filter>
<filter-name>Router</filter-name>
<filter-class>com.metamug.mason.Router</filter-class>
</filter>
<filter-mapping>
<filter-name>Router</filter-name>
<url-pattern>/rest/*</url-pattern>
</filter-mapping>
The *filter-name* has to be *Router* for it to be overwritten
------------------------------
You can view, comment on, or merge this pull request online at:
#110
Commit Summary
- Added @webfilter annotation for Router
File Changes
- *M* pom.xml <https://github.com/metamug/mason/pull/110/files#diff-0>
(572)
- *M* src/main/java/com/metamug/mason/Router.java
<https://github.com/metamug/mason/pull/110/files#diff-1> (437)
- *M* src/main/java/com/metamug/mason/service/ConnectionProvider.java
<https://github.com/metamug/mason/pull/110/files#diff-2> (86)
Patch Links:
- https://github.com/metamug/mason/pull/110.patch
- https://github.com/metamug/mason/pull/110.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#110?email_source=notifications&email_token=AAMA5OBI4W5AXDAQ5NEKSQ3QYRXUJA5CNFSM4J2Y3VSKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IAPIVIQ>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMA5OB6WXWUYOUYA5NB7SDQYRXUJANCNFSM4J2Y3VSA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added WebFilter annotation on
Routerclass to avoid so that entry inweb.xml(this will work for Servlet API 3.x+) The default URL pattern is set to /rest/* which can be overwritten from web.xml fileThe filter-name has to be Router for it to be overwritten