Draft
Conversation
Co-authored-by: ericatallah <eric.atallah@gmail.com>
```
error: Failed to send reveal transaction
because: JSON-RPC error: RPC error response: RpcError { code: -26, message: "non-mandatory-script-verify-flag (Invalid Schnorr signature)", data: None }
```
``` thread 'main' panicked at 'signature hash should compute: PrevoutKind', src/subcommand/wallet/inscribe.rs:360:8 ```
reveal TX for inscriptions containing a parent.
Ignore malformed inscriptions. Co-authored-by: Clarke Benedict <clarke.plumo@gmail.com>
Indirect pull from https://github.com/raphjaph/ord/pull/3/commits Props to @ericatallah for contributing this
…into collections-no-psbt
Formatting Debug logging
Clippy
Co-authored-by: Greg Martin <gm7t2@gmail.com> Co-authored-by: raphjaph <raphjaph@protonmail.com>
Co-authored-by: Greg Martin <gm7t2@gmail.com> Co-authored-by: raphjaph <raphjaph@protonmail.com>
…nals#1904) Co-authored-by: Greg Martin <gm7t2@gmail.com> Co-authored-by: raphjaph <raphjaph@protonmail.com>
Why:
- Some generative art collections have inscribed all art within a single
parent inscription to save considerable storage space on the
blockchain.
- The ord explorer is unable to currently support collections inscribed
in this manner. This commit adds this support.
What:
- In order to support these generative art collections, we need to be able
to inscribe the metadata for children in an agreed upon JSON spec.
- These child inscriptions are JSON documents containing url parameters
that instruct the parent inscription to
render a specific item in the collection.
How:
- Since all art is contained in the parent, we added a simple redirect to
render the parent inscription with included url parameters.
- There are 3 constraints which must be in the child inscription before
the redirect can happen:
1. The child inscription must have a parent inscription.
2. The child inscription's body data must be valid JSON.
3. The child inscription's body JSON data must contain a field named
"is_ord_pointer", with any value.
Proposed JSON standard:
```
{
"is_pointer": 1,
"url_params": ["tokenID=4969"],
}
```
Related Issue:
- https://github.com/casey/ord/issues/783
Co-authored-by: Clarke Plumo <clarke.plumo@gmail.com>
Co-authored-by: Clarke Plumo <clarke.plumo@gmail.com>
fix redirect to only include '?' if url_params are present in child JSON Co-authored-by: Clarke Plumo <clarke.plumo@gmail.com>
The child InscriptionId index was incorrectly set to 0. When inscribing with a parent, the child input sits at index 1. This commit sets the index to 1.
Co-authored-by: Clarke Plumo <clarke.plumo@gmail.com>
Rebase ord5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch will be maintained separate from
masterfor now, and will be deployed on the OCM Ordinal explorer machine.