Open
Conversation
Author
|
@fxprunayre please have a look thanks. |
fxprunayre
requested changes
Aug 21, 2018
| isofunc = new iso19139.Functions(handlers: handlers, f:f, env:env, commonHandlers: commonHandlers) | ||
| matchers = new Matchers(handlers: handlers, f:f, env:env) | ||
| packageViews = [ | ||
| 'mdb:identificationInfo', 'gmd:metadataMaintenance', 'gmd:metadataConstraints', 'mdb:spatialRepresentationInfo', |
Contributor
There was a problem hiding this comment.
Still some gmd namespace ref. Should be mdb here for most of them.
| handlers.add name: 'BBox Element', select: matchers.isBBox, bboxEl(false) | ||
| handlers.add name: 'Polygon Element', select: matchers.isPolygon, polygonEl(false) | ||
| handlers.add 'gex:geographicElement', commonHandlers.processChildren{it.children()} | ||
| handlers.add 'gmd:extentTypeCode', extentTypeCodeEl |
| def localeEls = { els -> | ||
| def locales = [] | ||
| els.each { | ||
| it.'gmd:PT_Locale'.each { loc -> |
Contributor
There was a problem hiding this comment.
lan here, and not gmd after for charset and language. Charset is now characterEncoding
| String thumbnailUrl; | ||
| if (img.startsWith("http://") || img.startsWith("https://")) { | ||
| thumbnailUrl = img.replace("&fname", "&fname"); | ||
| } else if (!isSmallImage(img) || !hasLargeGraphic) { |
Contributor
There was a problem hiding this comment.
This can be removed. Not used anymore in GN
| def f | ||
| def env | ||
|
|
||
| def isUrlEl = {!it.'gmd:URL'.text().isEmpty()} |
Contributor
There was a problem hiding this comment.
URL does not exist anymore here. They are CharacterString and can be multilingual.
| * Rome - Italy. email: geonetwork@osgeo.org | ||
| */ | ||
|
|
||
| package iso191153 |
Contributor
There was a problem hiding this comment.
Would name it iso19115_3 like the package name for Java classes:
package org.fao.geonet.schema.iso19115_3;
| /** | ||
| * Creates the {@link org.fao.geonet.api.records.formatters.groovy.util.Summary} instance for the iso19139 class. | ||
| * | ||
| * @author Jesse on 11/18/2014. |
| * Rome - Italy. email: geonetwork@osgeo.org | ||
| */ | ||
|
|
||
| def isoHandlers = new iso19139.Handlers(handlers, f, env) |
| # Rome - Italy. email: geonetwork@osgeo.org | ||
| # | ||
|
|
||
| schemasToLoad=iso19139 |
fxprunayre
added a commit
to camptocamp/iso19115-3
that referenced
this pull request
Sep 12, 2018
* Address most of the comments requested in PR metadata101#34 * Remove all 19139 namespace ref * URL is a normal CharacterString now * Aggregates are AssociatedResources * Remove small/large thumbnails concept code which does not exist anymore * Remove useless translation. This plugin is only available in english and french for now ... we should probably plan for more testing in here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.