chore: remove mb-rs as dependancy#20
Open
RustyNova016 wants to merge 4 commits intometabrainz:masterfrom
Open
Conversation
Collaborator
Author
|
No idea why the test fail as I haven't changed anything remotely tokio related? Maybe a flaky test? Probably should use nextest to check for those as well |
RustyNova016
force-pushed
the
integrate_mb_rs
branch
from
16108e6 to
574ad75
Compare
RustyNova016
commented
Mar 25, 2025
So funnily enough, the current crate had the tokio runtime feature enabled through mb_rs, and was the only thing preventing it from crashing and burning when spawning a `tokio::Task` Renabled it, and it allows purging the async_std runtime which was pulled in for nothing
RustyNova016
force-pushed
the
integrate_mb_rs
branch
from
69924bc to
57a70ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require #19 to pass first