Skip to content

Refactor/structs replace jsonvalue#18

Draft
yellowHatpro wants to merge 4 commits intomasterfrom
refactor/structs-replace-jsonvalue
Draft

Refactor/structs replace jsonvalue#18
yellowHatpro wants to merge 4 commits intomasterfrom
refactor/structs-replace-jsonvalue

Conversation

@yellowHatpro
Copy link
Collaborator

  • Replaced JsonValue with structs

@RustyNova016
Copy link
Collaborator

You may want to remove some of those options. For fields that aren't optional you can just put the type and not have to worry about it being an option ;) (Although you need to be sure they aren't optional, which isn't always clear cough musicbrainz API)

@yellowHatpro
Copy link
Collaborator Author

@RustyNova016 haha, thanks for the suggestion. Sorry I was inactive last week, so couldn't do much. I was doubtful about the types, so I ended up making them all optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants