TorchStoreStateDict #90
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
LucasLLC
reviewed
Jan 5, 2026
Contributor
LucasLLC
left a comment
LucasLLC
left a comment
There was a problem hiding this comment.
This is awesome! Impressed to see so much progress in a short time span.
Some recommended next steps:
-
Let's profile the current implementation and see what kind of speedup we're getting on batch put vs. none-batch put. Could be helpful to add some fine-grained logging (e.g. check out latency_tracker)
-
Next solid step would be to unpack the state dict within the storage volume
-
Once this is done, we can take a look at what it would take to "fetch in batch" as well
| MODEL_LINER_LENGTH = 10 | ||
|
|
||
|
|
||
| def _setup_process_group(): |
Contributor
There was a problem hiding this comment.
I wonder if it's worth putting this function in a helper in tests/utils since it's used in multiple places?
https://github.com/meta-pytorch/torchstore/blob/main/tests/utils.py#L105
LucasLLC
reviewed
Jan 7, 2026
LucasLLC
reviewed
Jan 7, 2026
LucasLLC
reviewed
Jan 7, 2026
LucasLLC
reviewed
Jan 7, 2026
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concatenate tensors into one blob of bytes for sending across transport (RDMA, Gloo, etc.) instead of sending one by one. In theory this should be faster than sending one by one due to overhead from transport buffers.