Skip to content

[torchft] Only reset_fr_recording_nccl if that attribute is available#314

Open
TimothySeah wants to merge 3 commits intometa-pytorch:mainfrom
TimothySeah:tseah/check-reset-fr-recording-nccl-attribute
Open

[torchft] Only reset_fr_recording_nccl if that attribute is available#314
TimothySeah wants to merge 3 commits intometa-pytorch:mainfrom
TimothySeah:tseah/check-reset-fr-recording-nccl-attribute

Conversation

@TimothySeah
Copy link

Otherwise this raises an exception when running a torchft training job in an environment without nccl e.g. cpu-only with gloo.

Signed-off-by: Timothy Seah <tseah@anyscale.com>
@meta-cla
Copy link

meta-cla bot commented Feb 21, 2026

Hi @TimothySeah!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link

meta-cla bot commented Feb 21, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 21, 2026
Copy link
Member

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Timothy Seah <tseah@anyscale.com>
Signed-off-by: Timothy Seah <tseah@anyscale.com>
@meta-codesync
Copy link

meta-codesync bot commented Mar 4, 2026

@d4l3k has imported this pull request. If you are a Meta employee, you can view this in D95139843.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants