Configure expected_replicas to avoid running tasks with unexpected re…#303
Open
zhengchenyu wants to merge 1 commit intometa-pytorch:mainfrom
Open
Configure expected_replicas to avoid running tasks with unexpected re…#303zhengchenyu wants to merge 1 commit intometa-pytorch:mainfrom
zhengchenyu wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes we want to ensure a fixed
total_batch_size.Generally,
local_batch_sizeis fixed, and we can adjustaccumulation_stepsbased onreplica_world_sizeto maintain a fixedtotal_batch_size.However, sometimes
replica_world_sizecannot guarantee an integeraccumulation_steps. For example, iflocal_batch_size = 4andtotal_batch_size = 16, andreplica_world_sizeis 3, it's difficult to assign a positive integer value toaccumulation_steps. We can avoid this problem if we can restrict thereplica_world_sizeto certain specific values. For example, in this case, ifexpected_replicas = 1, 2, 4, then the correspondingaccumulation_stepswill be4,2,1, thus solving the problem.related issue: #302