Add TorchStore weight sync to Generator v1 #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@JenniferWang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90775552. |
2 tasks
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 21, 2026
Summary: ## tl;dr Adds ForgeMonarchExecutor and ForgeWorkerWrapper to enable weight synchronization via TorchStore for RL training loops (e.g., GRPO). Specifically, the diff serialize the TochStore controller Actor to MonarchExecutor for sharing the controller. ## Test Plan [-] Weight update correctness test: `TORCHSTORE_RDMA_ENABLED=0 PYTHONPATH=. pytest -s tests/integration_tests/test_policy_update.py::TestWeightSync::test_sanity_check --config tests/integration_tests/fixtures/qwen3_1_7b_tp.yaml` [-] Local host: `python -m apps.grpo.main --config apps/grpo/qwen3_1_7b.yaml` [-] Remote host: https://www.internalfb.com/msl/studio/runs/mast/qwen3_1_7b_mast-cve6ce%3APRODUCTION%3A0/logs?attempt=0&taskGroups=trainer%3A0%2Cref_model_0%3A0%2Cgenerator_0%3A0%2Cclient%3A0&statusFilter=PENDING%2CRUNNING%2CCOMPLETE%2CFAILED%2CABANDONED%2CSTOPPING&logarithm=%7B%22after%22%3A10%2C%22before%22%3A20%7D ## Next Steps [ ] implement the prefetch logic & shared memory [ ] Add metric similar to generator v0 [ ] Perf/Throughput testing compared to generator v0 Differential Revision: D90775552
facebook-github-bot
force-pushed
the
export-D90775552
branch
from
9c6905e to
f4c88c2
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 21, 2026
Summary: ## tl;dr Adds ForgeMonarchExecutor and ForgeWorkerWrapper to enable weight synchronization via TorchStore for RL training loops (e.g., GRPO). Specifically, the diff serialize the TochStore controller Actor to MonarchExecutor for sharing the controller. ## Test Plan [-] Weight update correctness test: `TORCHSTORE_RDMA_ENABLED=0 PYTHONPATH=. pytest -s tests/integration_tests/test_policy_update.py::TestWeightSync::test_sanity_check --config tests/integration_tests/fixtures/qwen3_1_7b_tp.yaml` [-] Local host: `python -m apps.grpo.main --config apps/grpo/qwen3_1_7b.yaml` [-] Remote host: https://www.internalfb.com/msl/studio/runs/mast/qwen3_1_7b_mast-cve6ce%3APRODUCTION%3A0/logs?attempt=0&taskGroups=trainer%3A0%2Cref_model_0%3A0%2Cgenerator_0%3A0%2Cclient%3A0&statusFilter=PENDING%2CRUNNING%2CCOMPLETE%2CFAILED%2CABANDONED%2CSTOPPING&logarithm=%7B%22after%22%3A10%2C%22before%22%3A20%7D ## Next Steps [ ] implement the prefetch logic & shared memory [ ] Add metric similar to generator v0 [ ] Perf/Throughput testing compared to generator v0 Differential Revision: D90775552
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 21, 2026
Summary: ## tl;dr Adds ForgeMonarchExecutor and ForgeWorkerWrapper to enable weight synchronization via TorchStore for RL training loops (e.g., GRPO). Specifically, the diff serialize the TochStore controller Actor to MonarchExecutor for sharing the controller. ## Test Plan [-] Weight update correctness test: `TORCHSTORE_RDMA_ENABLED=0 PYTHONPATH=. pytest -s tests/integration_tests/test_policy_update.py::TestWeightSync::test_sanity_check --config tests/integration_tests/fixtures/qwen3_1_7b_tp.yaml` [-] Local host: `python -m apps.grpo.main --config apps/grpo/qwen3_1_7b.yaml` [-] Remote host: https://www.internalfb.com/msl/studio/runs/mast/qwen3_1_7b_mast-cve6ce%3APRODUCTION%3A0/logs?attempt=0&taskGroups=trainer%3A0%2Cref_model_0%3A0%2Cgenerator_0%3A0%2Cclient%3A0&statusFilter=PENDING%2CRUNNING%2CCOMPLETE%2CFAILED%2CABANDONED%2CSTOPPING&logarithm=%7B%22after%22%3A10%2C%22before%22%3A20%7D ## Next Steps [ ] implement the prefetch logic & shared memory [ ] Add metric similar to generator v0 [ ] Perf/Throughput testing compared to generator v0 Differential Revision: D90775552
Summary: ## tl;dr Adds ForgeMonarchExecutor and ForgeWorkerWrapper to enable weight synchronization via TorchStore for RL training loops (e.g., GRPO). Specifically, the diff serialize the TochStore controller Actor to MonarchExecutor for sharing the controller. ## Test Plan [-] Weight update correctness test: `TORCHSTORE_RDMA_ENABLED=0 PYTHONPATH=. pytest -s tests/integration_tests/test_policy_update.py::TestWeightSync::test_sanity_check --config tests/integration_tests/fixtures/qwen3_1_7b_tp.yaml` [-] Local host: `python -m apps.grpo.main --config apps/grpo/qwen3_1_7b.yaml` [-] Remote host: https://www.internalfb.com/msl/studio/runs/mast/qwen3_1_7b_mast-cve6ce%3APRODUCTION%3A0/logs?attempt=0&taskGroups=trainer%3A0%2Cref_model_0%3A0%2Cgenerator_0%3A0%2Cclient%3A0&statusFilter=PENDING%2CRUNNING%2CCOMPLETE%2CFAILED%2CABANDONED%2CSTOPPING&logarithm=%7B%22after%22%3A10%2C%22before%22%3A20%7D ## Next Steps [ ] implement the prefetch logic & shared memory [ ] Add metric similar to generator v0 [ ] Perf/Throughput testing compared to generator v0 Differential Revision: D90775552
facebook-github-bot
force-pushed
the
export-D90775552
branch
from
f4c88c2 to
e475eb3
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 23, 2026
Summary: ## tl;dr Adds ForgeMonarchExecutor and ForgeWorkerWrapper to enable weight synchronization via TorchStore for RL training loops (e.g., GRPO). Specifically, the diff serialize the TochStore controller Actor to MonarchExecutor for sharing the controller. ## Test Plan [-] Weight update correctness test: `TORCHSTORE_RDMA_ENABLED=0 PYTHONPATH=. pytest -s tests/integration_tests/test_policy_update.py::TestWeightSync::test_sanity_check --config tests/integration_tests/fixtures/qwen3_1_7b_tp.yaml` [-] Local host: `python -m apps.grpo.main --config apps/grpo/qwen3_1_7b.yaml` [-] Remote host: https://www.internalfb.com/msl/studio/runs/mast/qwen3_1_7b_mast-cve6ce%3APRODUCTION%3A0/logs?attempt=0&taskGroups=trainer%3A0%2Cref_model_0%3A0%2Cgenerator_0%3A0%2Cclient%3A0&statusFilter=PENDING%2CRUNNING%2CCOMPLETE%2CFAILED%2CABANDONED%2CSTOPPING&logarithm=%7B%22after%22%3A10%2C%22before%22%3A20%7D ## Next Steps [ ] implement the prefetch logic & shared memory [ ] Add metric similar to generator v0 [ ] Perf/Throughput testing compared to generator v0 Differential Revision: D90775552
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #710 +/- ##
==========================================
- Coverage 78.33% 71.40% -6.93%
==========================================
Files 36 41 +5
Lines 4209 4288 +79
==========================================
- Hits 3297 3062 -235
- Misses 912 1226 +314 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 23, 2026
Summary: ## tl;dr Adds ForgeMonarchExecutor and ForgeWorkerWrapper to enable weight synchronization via TorchStore for RL training loops (e.g., GRPO). Specifically, the diff serialize the TochStore controller Actor to MonarchExecutor for sharing the controller. ## Test Plan [-] Weight update correctness test: `TORCHSTORE_RDMA_ENABLED=0 PYTHONPATH=. pytest -s tests/integration_tests/test_policy_update.py::TestWeightSync::test_sanity_check --config tests/integration_tests/fixtures/qwen3_1_7b_tp.yaml` [-] Local host: `python -m apps.grpo.main --config apps/grpo/qwen3_1_7b.yaml` [-] Remote host: https://www.internalfb.com/msl/studio/runs/mast/qwen3_1_7b_mast-cve6ce%3APRODUCTION%3A0/logs?attempt=0&taskGroups=trainer%3A0%2Cref_model_0%3A0%2Cgenerator_0%3A0%2Cclient%3A0&statusFilter=PENDING%2CRUNNING%2CCOMPLETE%2CFAILED%2CABANDONED%2CSTOPPING&logarithm=%7B%22after%22%3A10%2C%22before%22%3A20%7D ## Next Steps [ ] implement the prefetch logic & shared memory [ ] Add metric similar to generator v0 [ ] Perf/Throughput testing compared to generator v0 Differential Revision: D90775552
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
tl;dr
Adds ForgeMonarchExecutor and ForgeWorkerWrapper to enable weight synchronization
via TorchStore for RL training loops (e.g., GRPO). Specifically, the diff serialize the TochStore controller Actor to MonarchExecutor for sharing the controller.
Test Plan
[-] Weight update correctness test:
TORCHSTORE_RDMA_ENABLED=0 PYTHONPATH=. pytest -s tests/integration_tests/test_policy_update.py::TestWeightSync::test_sanity_check --config tests/integration_tests/fixtures/qwen3_1_7b_tp.yaml[-] Local host:
python -m apps.grpo.main --config apps/grpo/qwen3_1_7b.yaml[-] Remote host: https://www.internalfb.com/msl/studio/runs/mast/qwen3_1_7b_mast-cve6ce%3APRODUCTION%3A0/logs?attempt=0&taskGroups=trainer%3A0%2Cref_model_0%3A0%2Cgenerator_0%3A0%2Cclient%3A0&statusFilter=PENDING%2CRUNNING%2CCOMPLETE%2CFAILED%2CABANDONED%2CSTOPPING&logarithm=%7B%22after%22%3A10%2C%22before%22%3A20%7D
Next Steps
[ ] implement the prefetch logic & shared memory
[ ] Add metric similar to generator v0
[ ] Perf/Throughput testing compared to generator v0
Differential Revision: D90775552