Skip to content

Add qwen3_30b_a3b.yaml config for test_policy_update.py #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
daniellepintz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add qwen3_30b_a3b.yaml config for test_policy_update.py #682

daniellepintz wants to merge 1 commit into from

Conversation

@daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Dec 27, 2025

Summary:
Add a config to test weight sync for Qwen3 30B MoE model
Note: the test will fail with this config until we update the torchtitan version.

Differential Revision: D89833611

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 27, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 27, 2025

@daniellepintz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89833611.

daniellepintz added a commit that referenced this pull request Dec 27, 2025
@daniellepintz @meta-codesync
Upgrade torchtitan version in versions.sh to v0.2.1
8c22445 
Summary: A new stable version of torchtitan was just released (v0.2.1) corresponding to the commit here. The new version includes a [fix](pytorch/torchtitan@fb54971) to a bug which will fix our weight sync test for Qwen 30B MoE (#682)

Differential Revision: D89833771
@daniellepintz daniellepintz mentioned this pull request Dec 27, 2025
Closed
daniellepintz added a commit that referenced this pull request Dec 27, 2025
@daniellepintz @meta-codesync
Upgrade torchtitan version in versions.sh to v0.2.1 (#683)
de019b3 
Summary:
Pull Request resolved: #683

A new stable version of torchtitan was just released (v0.2.1) corresponding to the commit here. The new version includes a [fix](pytorch/torchtitan@fb54971) to a bug which will fix our weight sync test for Qwen 30B MoE (#682)

Differential Revision: D89833771
@JenniferWang
Copy link
Contributor

JenniferWang commented Dec 29, 2025 •
edited
Loading

This test is used for two purposes

  • Correctness check for onboarding new model and therefore the test can run on any model config
  • Correctness check for changing infra code (e.g. Generator) and therefore it's a test and shall use a small model config.

In general,

  1. Please do not introduce new test fixture that fails the test.
  2. Do not introduce new test fixture unless it tests new aspect of our infra.

Also, this test is not configured to run continuously yet ... so it's not used to test infra regression :(

@JenniferWang JenniferWang reopened this Dec 29, 2025
allenwang28
allenwang28 approved these changes Dec 30, 2025
View reviewed changes
Copy link
Contributor

@allenwang28 allenwang28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

daniellepintz added a commit that referenced this pull request Jan 16, 2026
@daniellepintz @meta-codesync
Add qwen3_30b_a3b.yaml config for test_policy_update.py (#682)
19d27ed 
Summary:
Pull Request resolved: #682

Add a config to test weight sync for Qwen3 30B MoE model
Note: the test will fail with this config until we update the torchtitan version.

Reviewed By: allenwang28

Differential Revision: D89833611
daniellepintz added a commit that referenced this pull request Jan 17, 2026
@daniellepintz @meta-codesync
Add qwen3_30b_a3b.yaml config for test_policy_update.py (#682)
6945075 
Summary:
Pull Request resolved: #682

Add a config to test weight sync for Qwen3 30B MoE model
Note: the test will fail with this config until we update the torchtitan version.

Reviewed By: allenwang28

Differential Revision: D89833611
facebook-github-bot pushed a commit that referenced this pull request Jan 17, 2026
@daniellepintz @facebook-github-bot
Add qwen3_30b_a3b.yaml config for test_policy_update.py (#682)
aadd21c 
Summary:

Add a config to test weight sync for Qwen3 30B MoE model
Note: the test will fail with this config until we update the torchtitan version.

Reviewed By: allenwang28

Differential Revision: D89833611
facebook-github-bot pushed a commit that referenced this pull request Jan 17, 2026
@daniellepintz @facebook-github-bot
Add qwen3_30b_a3b.yaml config for test_policy_update.py (#682)
d47d8b2 
Summary:

- Add a config to test weight sync for Qwen3 30B MoE model
- Add the config to run in the CI on every commit to main
- Fix docstring in test_policy_update.py

Reviewed By: allenwang28

Differential Revision: D89833611
daniellepintz added a commit that referenced this pull request Jan 19, 2026
@daniellepintz @meta-codesync
Add qwen3_30b_a3b.yaml config for test_policy_update.py (#682)
2411f3d 
Summary:
Pull Request resolved: #682

- Add a config to test weight sync for Qwen3 30B MoE model
- Add the config to run in the CI on every commit to main
- Fix docstring in test_policy_update.py

Reviewed By: allenwang28

Differential Revision: D89833611
daniellepintz added a commit that referenced this pull request Jan 19, 2026
@daniellepintz @meta-codesync
Add qwen3_30b_a3b.yaml config for test_policy_update.py (#682)
b79a428 
Summary:
Pull Request resolved: #682

- Add a config to test weight sync for Qwen3 30B MoE model
- Add the config to run in the CI on every commit to main
- Fix docstring in test_policy_update.py

Reviewed By: allenwang28

Differential Revision: D89833611
daniellepintz added a commit that referenced this pull request Jan 21, 2026
@daniellepintz @meta-codesync
Add qwen3_30b_a3b.yaml config for test_policy_update.py (#682)
6f57230 
Summary:
Pull Request resolved: #682

- Add a config to test weight sync for Qwen3 30B MoE model
- Add the config to run in the CI on every commit to main
- Fix docstring in test_policy_update.py

Reviewed By: allenwang28

Differential Revision: D89833611
facebook-github-bot pushed a commit that referenced this pull request Jan 21, 2026
@daniellepintz @facebook-github-bot
Add qwen3_30b_a3b.yaml config for test_policy_update.py (#682)
22cc567 
Summary:

- Add a config to test weight sync for Qwen3 30B MoE model
- Add the config to run in the CI on every commit to main
- Fix docstring in test_policy_update.py

Reviewed By: allenwang28

Differential Revision: D89833611
daniellepintz added a commit that referenced this pull request Jan 23, 2026
@daniellepintz @meta-codesync
Add qwen3_30b_a3b.yaml config for test_policy_update.py (#682)
0d5b969 
Summary:
Pull Request resolved: #682

- Add a config to test weight sync for Qwen3 30B MoE model
- Add the config to run in the CI on every commit to main
- Fix docstring in test_policy_update.py

Reviewed By: allenwang28

Differential Revision: D89833611
@daniellepintz @meta-codesync
Add qwen3_30b_a3b.yaml config for test_policy_update.py (#682)
0130e8f 
Summary:
Pull Request resolved: #682

- Add a config to test weight sync for Qwen3 30B MoE model
- Add the config to run in the CI on every commit to main
- Fix docstring in test_policy_update.py

Reviewed By: allenwang28

Differential Revision: D89833611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allenwang28 allenwang28 allenwang28 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daniellepintz @JenniferWang @allenwang28