Skip to content

Conversation

@JenniferWang
Copy link
Contributor

@JenniferWang JenniferWang commented Dec 22, 2025

Differential Revision: D89667182

Test plan:

(forge-c) [jiyue@devgpu004.rva5 ~/fbsource/fbcode/pytorch/torchforge (arcpatch-D89568072)]$ pip list | grep vllm
vllm                              0.13.0
(forge-c) [jiyue@devgpu004.rva5 ~/fbsource/fbcode/pytorch/torchforge (arcpatch-D89568072)]$  pytest -v tests/integration_tests/test_vllm_policy_correctness.py
=============================== test session starts ===============================
platform linux -- Python 3.12.12, pytest-9.0.2, pluggy-1.6.0 -- /home/jiyue/.conda/envs/forge-c/bin/python3.12
cachedir: .pytest_cache
rootdir: /data/users/jiyue/fbsource/fbcode/pytorch/torchforge
configfile: pyproject.toml
plugins: typeguard-4.4.4, anyio-4.12.0, timeout-2.4.0, cov-7.0.0, asyncio-1.3.0
asyncio: mode=Mode.STRICT, debug=False, asyncio_default_fixture_loop_scope=None, asyncio_default_test_loop_scope=function
collected 2 items                                                                 

tests/integration_tests/test_vllm_policy_correctness.py::test_same_output PASSED [ 50%]
tests/integration_tests/test_vllm_policy_correctness.py::test_cache_usage PASSED [100%]

================================ warnings summary =================================
<frozen importlib._bootstrap>:488
  <frozen importlib._bootstrap>:488: DeprecationWarning: builtin type SwigPyPacked has no __module__ attribute

<frozen importlib._bootstrap>:488
  <frozen importlib._bootstrap>:488: DeprecationWarning: builtin type SwigPyObject has no __module__ attribute

tests/integration_tests/test_vllm_policy_correctness.py::test_same_output
tests/integration_tests/test_vllm_policy_correctness.py::test_cache_usage
  /home/jiyue/.conda/envs/forge-c/lib/python3.12/multiprocessing/popen_fork.py:66: DeprecationWarning: This process (pid=1854140) is multi-threaded, use of fork() may lead to deadlocks in the child.
    self.pid = os.fork()

tests/integration_tests/test_vllm_policy_correctness.py::test_same_output
tests/integration_tests/test_vllm_policy_correctness.py::test_cache_usage
  /data/users/jiyue/fbsource/fbcode/pytorch/torchforge/src/forge/controller/provisioner.py:384: DeprecationWarning: setup_env_for_distributed is deprecated and will be removed in monarch 0.3.0. Use monarch.spmd.setup_torch_elastic_env instead.
    await setup_env_for_distributed(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
==================== 2 passed, 6 warnings in 66.41s (0:01:06) =====================
sys:1: DeprecationWarning: builtin type swigvarlink has no __module__ attribute

…in scripts/install.s (#667)

Summary:

There's no need to specify the package version for `torchmonarch-nightly` and `torchtitan` in two separate places. We leave the canonical version in `pyproject.yaml` and remove the ones from `assets/versions.sh`

Differential Revision: D89667000
Differential Revision: D89667182
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 22, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 22, 2025

@JenniferWang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89667182.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants