Skip to content

Add all compilatino metrics to tlparse output log#172

Merged
yushangdi merged 1 commit intomainfrom
sy_more_compile_metrics
Feb 26, 2026
Merged

Add all compilatino metrics to tlparse output log#172
yushangdi merged 1 commit intomainfrom
sy_more_compile_metrics

Conversation

@yushangdi
Copy link
Contributor

@yushangdi yushangdi commented Feb 26, 2026

At src/lib.rs:700, the JSON payload is deserialized into an Envelope, which contains compilation_metrics:
Option<CompilationMetricsMetadata>. When that inner struct is deserialized, serde automatically routes
unknown keys like dynamo_config, is_forward, frame_key, etc. into the extra map.

example output:

At the end of tlparse/tl_out/-_0_0_0/compilation_metrics_2.html

Screenshot 2026-02-25 at 5 38 34 PM

This would especially be useful when checking dynamo_config and would have been useful when debugging https://fb.workplace.com/groups/1075192433118967/permalink/1889257968379072/. While we can also see some of the configs in the fx_runnable and chromium events, 1) we don't have fx_runnable when the backend is not inductor. and 2) it's annoying to have to click into perfetto trace to see dynamo configs.

@yushangdi yushangdi requested a review from angelayi February 26, 2026 01:39
@meta-cla meta-cla bot added the cla signed label Feb 26, 2026
src/parsers.rs Outdated
String::new()
} else {
let mut html = String::from(
"<h2>Other Metrics</h2>\n<table>\n<tr><th>Key</th><th>Value</th></tr>\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I feel like in the past the tlparse code has mostly been structured like, the parser organizes the values from the log files, and then templates.rs contains html/formatting changes such as the heading, and the loop through the dictionary to place it in the html file nicely. Whereas this code just generates an html string

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, modified!

@yushangdi yushangdi force-pushed the sy_more_compile_metrics branch from 32d9a21 to 4c0629a Compare February 26, 2026 18:23
@yushangdi yushangdi requested a review from angelayi February 26, 2026 18:23
@yushangdi yushangdi merged commit ec2ffda into main Feb 26, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants