Add all compilatino metrics to tlparse output log#172
Merged
Conversation
angelayi
reviewed
Feb 26, 2026
src/parsers.rs
Outdated
| String::new() | ||
| } else { | ||
| let mut html = String::from( | ||
| "<h2>Other Metrics</h2>\n<table>\n<tr><th>Key</th><th>Value</th></tr>\n", |
Contributor
There was a problem hiding this comment.
nit: I feel like in the past the tlparse code has mostly been structured like, the parser organizes the values from the log files, and then templates.rs contains html/formatting changes such as the heading, and the loop through the dictionary to place it in the html file nicely. Whereas this code just generates an html string
32d9a21 to
4c0629a
Compare
angelayi
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At
src/lib.rs:700, the JSON payload is deserialized into an Envelope, which contains compilation_metrics:Option<CompilationMetricsMetadata>. When that inner struct is deserialized, serde automatically routesunknown keys like dynamo_config, is_forward, frame_key, etc. into the extra map.
example output:
At the end of
tlparse/tl_out/-_0_0_0/compilation_metrics_2.htmlThis would especially be useful when checking
dynamo_configand would have been useful when debugging https://fb.workplace.com/groups/1075192433118967/permalink/1889257968379072/. While we can also see some of the configs in the fx_runnable and chromium events, 1) we don't have fx_runnable when the backend is not inductor. and 2) it's annoying to have to click into perfetto trace to see dynamo configs.