Open
Conversation
facebook-github-bot
added
the
CLA Signed
atalman
reviewed
Jul 25, 2024
test/smoke_test/smoke_test.py
Outdated
| if options.s3: | ||
| s3_test() | ||
|
|
||
| if torchdata.__version__ >= "0.8.0": |
Contributor
There was a problem hiding this comment.
Please throw exception here if torchdata.__version__ != 0.8.0
We would need to route it later via input parameter. However this can be a followup PR
atalman
approved these changes
Jul 25, 2024
Contributor
atalman
left a comment
atalman
left a comment
There was a problem hiding this comment.
please address comment and we are good to merge
Contributor
Author
|
@atalman Is that change what you had in mind? Can you also confirm if it is fine to land this in main branch (with the check being about 0.8.0) and the cherry pick this to release/0.8 branch? |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1299
Note: Links to docs will display an error until the docs builds have been completed. ❌ 14 New FailuresAs of commit f4d0986 with merge base de5791b ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
gokulavasan
force-pushed
the
more-smoke-test
branch
from
d185e39 to
322712c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
title
Fixes #{issue number}
Changes